Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mat 7797 edit function #708

Merged
merged 13 commits into from
Jan 3, 2025
Merged

Mat 7797 edit function #708

merged 13 commits into from
Jan 3, 2025

Conversation

sb-cecilialiu
Copy link
Contributor

@sb-cecilialiu sb-cecilialiu commented Dec 20, 2024

MADiE PR

Jira Ticket: MAT-7797
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@sb-cecilialiu sb-cecilialiu requested a review from a team as a code owner December 20, 2024 16:42
Copy link
Contributor

@mcmcphillips mcmcphillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment related to the handling of functionNames here

MeasureAuthoringTool/madie-editor#417 (review)

That should be resolved before merging

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.03%. Comparing base (ede72a3) to head (87a4f50).
Report is 14 commits behind head on develop.

Files with missing lines Patch % Lines
...rc/components/editMeasure/editor/MeasureEditor.tsx 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #708      +/-   ##
===========================================
+ Coverage    81.00%   81.03%   +0.03%     
===========================================
  Files          305      305              
  Lines        10686    10712      +26     
  Branches      2311     2314       +3     
===========================================
+ Hits          8656     8681      +25     
  Misses        1449     1449              
- Partials       581      582       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sb-cecilialiu
Copy link
Contributor Author

@mcmcphillips I made the change in madie-editor, thanks Matt!

@sb-cecilialiu
Copy link
Contributor Author

The handling of the function names as Matt mentioned has already been done and approved in madie-editor PR 417 (MeasureAuthoringTool/madie-editor#417 (review))

@sb-cecilialiu sb-cecilialiu merged commit 3edadd3 into develop Jan 3, 2025
13 checks passed
@sb-cecilialiu sb-cecilialiu deleted the MAT-7797_editFunction branch January 3, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants