-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mat 7797 edit function #708
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a comment related to the handling of functionNames here
MeasureAuthoringTool/madie-editor#417 (review)
That should be resolved before merging
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #708 +/- ##
===========================================
+ Coverage 81.00% 81.03% +0.03%
===========================================
Files 305 305
Lines 10686 10712 +26
Branches 2311 2314 +3
===========================================
+ Hits 8656 8681 +25
Misses 1449 1449
- Partials 581 582 +1 ☔ View full report in Codecov by Sentry. |
@mcmcphillips I made the change in madie-editor, thanks Matt! |
…ie-measure into MAT-7797_editFunction
…horingTool/madie-measure into MAT-7797_editFunction
The handling of the function names as Matt mentioned has already been done and approved in madie-editor PR 417 (MeasureAuthoringTool/madie-editor#417 (review)) |
MADiE PR
Jira Ticket: MAT-7797
(Optional) Related Tickets:
Summary
All Submissions
DevSecOps
If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.
Reviewers
By Approving this PR you are attesting to the following: