Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

MAT-6704: Override moment.js version [FHIR] #2228

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

jkotanchik-SB
Copy link
Contributor

Pull requests into Bonnie require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable ("N/A") and ✅.

Submitter:

  • This pull request describes why these changes were made.
  • This PR is into the correct branch.
  • JIRA ticket for this PR:
  • JIRA ticket links to this PR
  • Code diff has been done and been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.)
  • If UI changes have been made, google WAVE plug-in has been executed to ensure no 508 issues were introduced.
  • Tests are included and test edge cases
  • Tests have been run locally and pass (remember to update Gemfile when applicable)
  • Code coverage has not gone down and all code touched or added is covered.
    • In rare situations, this may not be possible or applicable to a PR. In those situations:
      1. Note why this could not be done or is not applicable here:
      2. Add TODOs in the code noting that it requires a test
      3. Add a JIRA task to add the test and link it here:
  • Automated regression test(s) pass

If JIRA tests were used to supplement or replace automated tests:

  • JIRA test links:
  • Justification for using JIRA tests:
  • JIRA tests have been added to sprint

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases

If JIRA tests were used to supplement or replace automated tests:

  • JIRA tests have been run and pass
  • You agree with the justification for use of JIRA tests or have provided input on why you disagree

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

If JIRA tests were used to supplement or replace automated tests:

  • JIRA tests have been run and pass
  • You agree with the justification for use of JIRA tests or have provided input on why you disagree

@jkotanchik-SB jkotanchik-SB requested a review from a team as a code owner June 4, 2024 20:07
@jkotanchik-SB jkotanchik-SB self-assigned this Jun 4, 2024
@jkotanchik-SB jkotanchik-SB changed the title MAT-6704: Override moment.js version MAT-6704: Override moment.js version [FHIR] Jun 4, 2024
@jkotanchik-SB jkotanchik-SB force-pushed the feature/mat-6704-bump-moment-js-fhir branch from 0ad71f9 to c3fb9af Compare June 4, 2024 20:09
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.87%. Comparing base (ac2e5ea) to head (54d774d).
Report is 11 commits behind head on bonnie-on-fhir.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           bonnie-on-fhir    #2228   +/-   ##
===============================================
  Coverage           70.87%   70.87%           
===============================================
  Files                 140      140           
  Lines                8349     8349           
  Branches             1270     1270           
===============================================
  Hits                 5917     5917           
  Misses               1828     1828           
  Partials              604      604           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b3ad5f...54d774d. Read the comment docs.

@jkotanchik-SB jkotanchik-SB merged commit 902bafd into bonnie-on-fhir Jun 5, 2024
24 of 25 checks passed
@jkotanchik-SB jkotanchik-SB deleted the feature/mat-6704-bump-moment-js-fhir branch June 5, 2024 14:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants