Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

MAT-6385 Bonnie Test Case Coverage Drop to 98%- CMS161 #2192

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Conversation

adongare
Copy link
Contributor

@adongare adongare commented Nov 21, 2023

Pull cqm-execution v4.1.4 that fixes a couple of issues related to the equivalent operator(~) and entity id projecttacoma/cqm-execution#257

Pull requests into Bonnie require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable ("N/A") and ✅.

Submitter:

  • This pull request describes why these changes were made.
  • This PR is into the correct branch.
  • JIRA ticket for this PR: MAT-6385 Bonnie Test Case Coverage Drop to 98%- CMS161
  • JIRA ticket links to this PR
  • Code diff has been done and been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.)
  • If UI changes have been made, google WAVE plug-in has been executed to ensure no 508 issues were introduced.
  • Tests are included and test edge cases
  • Tests have been run locally and pass (remember to update Gemfile when applicable)
  • Test fixtures updated and documented as necessary ( see internal wiki )
  • Code coverage has not gone down and all code touched or added is covered.
    • In rare situations, this may not be possible or applicable to a PR. In those situations:
      1. Note why this could not be done or is not applicable here:
      2. Add TODOs in the code noting that it requires a test
      3. Add a JIRA task to add the test and link it here:
  • Automated regression test(s) pass

If JIRA tests were used to supplement or replace automated tests:

  • JIRA test links:
  • Justification for using JIRA tests:
  • JIRA tests have been added to sprint

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases

If JIRA tests were used to supplement or replace automated tests:

  • JIRA tests have been run and pass
  • You agree with the justification for use of JIRA tests or have provided input on why you disagree

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

If JIRA tests were used to supplement or replace automated tests:

  • JIRA tests have been run and pass
  • You agree with the justification for use of JIRA tests or have provided input on why you disagree

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Merging #2192 (e375730) into master (376692b) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2192   +/-   ##
=======================================
  Coverage   71.46%   71.46%           
=======================================
  Files          87       87           
  Lines        6293     6293           
  Branches      884      884           
=======================================
  Hits         4497     4497           
  Misses       1454     1454           
  Partials      342      342           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 376692b...e375730. Read the comment docs.

@adongare adongare marked this pull request as ready for review November 21, 2023 22:16
@sb-bdonohue sb-bdonohue merged commit 0b09d3c into master Nov 22, 2023
22 of 23 checks passed
@sb-bdonohue sb-bdonohue deleted the MAT-6385 branch November 22, 2023 15:44
sb-bdonohue added a commit that referenced this pull request Nov 22, 2023
* MAT-6385 Bonnie Test Case Coverage Drop to 98%- CMS161 (#2192)

* MAT-6385 Bonnie Test Case Coverage Drop to 98%- CMS161
pull cqm-execution v4.1.4

* remove unwanted links to external repos

* pinning version of passenger (#2194)

---------

Co-authored-by: Brendan Donohue <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants