Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

Revert Bonnie Version #2185

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Revert Bonnie Version #2185

merged 2 commits into from
Oct 4, 2023

Conversation

jkotanchik-SB
Copy link
Contributor

  • Revert "Increment Bonnie Proper version to 5.1.5"
  • Revert "Update bonnie version value"

Pull requests into Bonnie require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable ("N/A") and ✅.

Submitter:

  • This pull request describes why these changes were made.
  • This PR is into the correct branch.
  • JIRA ticket for this PR:
  • JIRA ticket links to this PR
  • Code diff has been done and been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.)
  • If UI changes have been made, google WAVE plug-in has been executed to ensure no 508 issues were introduced.
  • Tests are included and test edge cases
  • Tests have been run locally and pass (remember to update Gemfile when applicable)
  • Test fixtures updated and documented as necessary ( see internal wiki )
  • Code coverage has not gone down and all code touched or added is covered.
    • In rare situations, this may not be possible or applicable to a PR. In those situations:
      1. Note why this could not be done or is not applicable here:
      2. Add TODOs in the code noting that it requires a test
      3. Add a JIRA task to add the test and link it here:
  • Automated regression test(s) pass

If JIRA tests were used to supplement or replace automated tests:

  • JIRA test links:
  • Justification for using JIRA tests:
  • JIRA tests have been added to sprint

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases

If JIRA tests were used to supplement or replace automated tests:

  • JIRA tests have been run and pass
  • You agree with the justification for use of JIRA tests or have provided input on why you disagree

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

If JIRA tests were used to supplement or replace automated tests:

  • JIRA tests have been run and pass
  • You agree with the justification for use of JIRA tests or have provided input on why you disagree

@jkotanchik-SB jkotanchik-SB self-assigned this Oct 4, 2023
@jkotanchik-SB jkotanchik-SB requested a review from a team October 4, 2023 17:50
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #2185 (9a69996) into master (17db583) will increase coverage by 21.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2185       +/-   ##
===========================================
+ Coverage   50.43%   71.46%   +21.02%     
===========================================
  Files          87       87               
  Lines        6293     6293               
  Branches      884      884               
===========================================
+ Hits         3174     4497     +1323     
+ Misses       2804     1454     -1350     
- Partials      315      342       +27     

see 53 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17db583...9a69996. Read the comment docs.

@jkotanchik-SB jkotanchik-SB merged commit 376692b into master Oct 4, 2023
19 of 20 checks passed
@jkotanchik-SB jkotanchik-SB deleted the revert-proper-version branch October 4, 2023 20:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants