Related links

[JaviviJR]

Added new dynamic field in profile section witch let us to add related links.

#839

[BentiGorlich]

Can you implement it the mastodon way where you have a name-link combination? So that each add link field has an associated name field.

[JaviviJR]

Can you implement it the mastodon way where you have a name-link combination? So that each add link field has an associated name field.

Do you want that user can add just links or whatever data user wants like Mastodon?

[BentiGorlich]

Limit it to links would be fine for me, but I don't think that it makes sense 🤔

[BentiGorlich]

Could you add phpDoc so we know which kind of array is returned? I really liked if the returned value would be of RelatedLink[] so an array of objects, so we can add some validation logic so we can mark links as "checked" or something so we know that the rel=me is actually correct

[JaviviJR]

Discussed Discussed on element chat.
I don't know a elegant way to denormalize the json field from table and return it on get method. This'll required some dependencies inside entity that I think is not a good practice.
Instead, I created a RelatedLinkDTO class and this will be returned in UserDTO.

[melroy89]

Can you implement it the mastodon way where you have a name-link combination? So that each add link field has an associated name field.

Agreed that would be helpful, so it's basically a key/value list.

[BentiGorlich]

I'd love if the add button would something like this (but that is not a requirement):

I noticed that the links are not yet displayed on the profile page. Are you planning on adding that in this PR?
(The activity pub representation of the fields is also missing, but I expected to do that myself anyways :) but if you'd like to try that as well, feel free to do so)

[BentiGorlich]

Oh and please change the target of the PR to dev/new_features

[JaviviJR]

I'd love if the add button would something like this (but that is not a requirement):

I noticed that the links are not yet displayed on the profile page. Are you planning on adding that in this PR? (The activity pub representation of the fields is also missing, but I expected to do that myself anyways :) but if you'd like to try that as well, feel free to do so)

Check it out with the new changes.
I tried to keep it centered in vertical line which separate the two fields, but I couldn't.

Also I modified userBox component to show related links in profile.

[BentiGorlich]

First of all thanks for your time and effort ❤️
I will have a look at it in the next days.

From your comment and screenshots I (already) have a few remarks (sorry 🙈):

I tried to keep it centered in vertical line which separate the two fields, but I couldn't.

I think I did it by making a div with a margin left the same size as the buttons and then just put text-align: center in there.

I modified userBox component to show related links in profile.

What happens when the value is not a link?

[melroy89]

There is a conflict with translations/messages.es.yaml. Ideally only change the English language file. And translate the rest in Weblate.

[melroy89]

Fixed merge conflicts..

Revisit the latest code changes

[melroy89]

Fix the php-cs-fixer

[melroy89]

PR should be ready for last review now.. I hope. 🥳

[BentiGorlich]

@JaviviJR did you push all your changes? The modifications of the edit profile page and the user box are not there, yet

[github-actions]

This PR is stale because it has been open 40 days with no activity.