[sql_server] Update the mz_sql_server_util::Client to support tunneling#32085
Merged
ParkMyCar merged 1 commit intoMaterializeInc:mainfrom Apr 7, 2025
Merged
Conversation
* introduces a new Config type that wraps tiberius::Config * adds a 'resources' field to mz_sql_server_util::Client that can be used to keep tunnels open * updates the 'cdc' example to use the new Client config
ParkMyCar
force-pushed
the
sql_server/client-with-tunneling
branch
from
28bb700 to
b541f05
Compare
ParkMyCar
changed the title
mz_sql_server_util::Client to support tunnellingmz_sql_server_util::Client to support tunneling
Merged
5 tasks
petrosagg
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
mz_sql_server_util::Clientto have initial support for tunneling by introducing our ownmz_sql_server_util::Configtype that wraps atiberius::Config. Currently the only tunneling supported is SSH, AWS PrivateLink is left as a TODO.Motivation
Nothing functionally changes yet, nor is the SSH tunneling testing, but it aligns our SQL Server Client with the Clients we use for Postgres and MySQL.
Progress towards: https://github.com/MaterializeInc/database-issues/issues/8762
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.