"fix" AutoSuggestBox has weird tab behavior #3765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-do not mark event as handled to enable "normal" TAB and Shift+TAB behavior
…that the base.OnPreviewKeyDown does not move focus to the next element
|
I revisited this issue again and after some testing it doesn't seem like this change (re-)introduced new bugs. |
Keboo
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
potential fix for #3761
From my manual testing this fixes both problems mentioned in the issue.
This is a first "working" version but probably not ready for prod yet.
The changes essentially only mark the
KeyEventArgs eevent as handled, if one of theAutoSuggestBox"specific" keys is pressed. Additionally the methodCommitValueSelectionnow returns aboolto indicate whether an item was selected or not.I think this is test-worthy and therefore WIP