Replace request with axios

[r0wanda]

Request is deprecated (request/request#3142), and axios is already part of this project's dependencies, so it feels more appropriate to stick to one http library. I tried to maintain the stream approach in the original request-based code.

[Mastermindzh]

Did you test this :) ?

Axios shouldn't be available in the renderer (and that calls downloadfile atm).

[r0wanda]

I did test it ;)
Also, why wouldn't axios be available in the renderer process? It looks like the only call to downloadfile is in the preload script, which isn't sandboxed. Sorry if this is an obvious question, I'm not very experienced with electron.

[Mastermindzh]

@Mar0xy, could you try testing it as well? I can't get @r0wanda's repo to work for me. Notifications are always shown without an icon.

@r0wanda, are you sure it's triggering? Can you add a Logger.log in both the success/catch blocks?
I've had this issue before with Axios not working when called directly from the renderer (which is what we're doing).

I don't know why it doesn't work, I've only ever managed to get it to work with request.

[Mastermindzh]

My testing gives me this:

I added the following log statements:

[sonarcloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[r0wanda]

I redesigned it a bit so that Axios is called in the main process through IPC. I tested it (more thoroughly this time) and it seems to work :)