Skip to content

Commit

Permalink
- Updated build config to make use of a base file that doesn't build …
Browse files Browse the repository at this point in the history
…anything.

  - This fixes the issue of unwanted extra build targets that were introduced with the electron-builder update
  • Loading branch information
Mastermindzh committed Jun 25, 2022
1 parent 207a61d commit fa9ab22
Show file tree
Hide file tree
Showing 10 changed files with 52 additions and 33 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## 4.0.1

- Updated build config to make use of a base file that doesn't build anything.
- This fixes the issue of unwanted extra build targets that were introduced with the electron-builder update

## 4.0.0

- Updated to Electron 19.0.5
Expand Down
33 changes: 33 additions & 0 deletions build/electron-builder.base.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
appId: com.rickvanlieshout.tidal-hifi
electronVersion: 19.0.5
electronDownload:
version: 19.0.5+wvcus
mirror: https://github.com/castlabs/electron-releases/releases/download/v
snap:
plugs:
- default
- screen-inhibit-control
linux:
category: Audio
target:
- dir
executableName: tidal-hifi
desktop:
Encoding: UTF-8
Name: tidal-hifi
GenericName: tidal-hifi
Comment: The web version of listen.tidal.com running in electron with hifi support thanks to widevine.
Icon: assets/icon.png
StartupNotify: true
Terminal: false
Type: Application
Categories: Network;Application;AudioVideo;Audio;Video
StartupWMClass: tidal-hifi
X-PulseAudio-Properties: media.role=music
mac:
category: public.app-category.entertainment
win:
icon: build/icon.png
artifactName: "tidalhifi"
appId: com.rickvanlieshout.tidalhifi
executableName: tidalhifi
2 changes: 1 addition & 1 deletion build/electron-builder.deb.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
extends: ./build/electron-builder.yml
extends: ./build/electron-builder.base.yml
linux:
category: Audio
icon: ./assets/icon.png
Expand Down
2 changes: 1 addition & 1 deletion build/electron-builder.pacman.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
extends: ./build/electron-builder.yml
extends: ./build/electron-builder.base.yml
linux:
category: Audio
icon: ./assets/icon.png
Expand Down
10 changes: 5 additions & 5 deletions build/electron-builder.rpm.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
extends: ./build/electron-builder.yml
extends: ./build/electron-builder.base.yml
linux:
category: Audio
icon: ./assets/TIDAL.icns
target:
- rpm
category: Audio
icon: ./assets/TIDAL.icns
target:
- rpm
2 changes: 1 addition & 1 deletion build/electron-builder.snap.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
extends: ./build/electron-builder.yml
extends: ./build/electron-builder.base.yml
linux:
category: Audio
icon: ./assets/icon.png
Expand Down
2 changes: 1 addition & 1 deletion build/electron-builder.unpacked.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
extends: ./build/electron-builder.yml
extends: ./build/electron-builder.base.yml
linux:
target:
- dir
20 changes: 0 additions & 20 deletions build/electron-builder.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,7 @@
appId: com.rickvanlieshout.tidal-hifi
electronVersion: 19.0.5
electronDownload:
version: 19.0.5+wvcus
mirror: https://github.com/castlabs/electron-releases/releases/download/v
snap:
plugs:
- default
- screen-inhibit-control
linux:
category: Audio
target:
Expand All @@ -17,21 +12,6 @@ linux:
- AppImage
- snap
- freebsd
executableName: tidal-hifi
desktop:
Encoding: UTF-8
Name: tidal-hifi
GenericName: tidal-hifi
Comment: The web version of listen.tidal.com running in electron with hifi support thanks to widevine.
Icon: assets/icon.png
StartupNotify: true
Terminal: false
Type: Application
Categories: Network;Application;AudioVideo;Audio;Video
StartupWMClass: tidal-hifi
X-PulseAudio-Properties: media.role=music
mac:
category: public.app-category.entertainment
win:
target: msi
icon: build/icon.png
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "tidal-hifi",
"version": "4.0.0",
"version": "4.0.1",
"description": "Tidal on Electron with widevine(hifi) support",
"main": "src/main.js",
"scripts": {
Expand All @@ -12,7 +12,8 @@
"build-snap": "electron-builder --publish=never -c ./build/electron-builder.snap.yml",
"build-arch": "electron-builder --publish=never -c ./build/electron-builder.pacman.yml",
"build-wl": "electron-builder --publish=never -c ./build/electron-builder.yml -wl",
"build-mac": "electron-builder --publish=never -c ./build/electron-builder.yml -m"
"build-mac": "electron-builder --publish=never -c ./build/electron-builder.yml -m",
"build-base": "electron-builder --publish=never -c ./build/electron-builder.base.yml"
},
"keywords": [
"electron",
Expand Down

0 comments on commit fa9ab22

Please sign in to comment.