Removed unnecessary PartialEq constraint from some stream trait impls.#314
Open
johnw42 wants to merge 1 commit intoMarwes:masterfrom
Open
Removed unnecessary PartialEq constraint from some stream trait impls.#314johnw42 wants to merge 1 commit intoMarwes:masterfrom
johnw42 wants to merge 1 commit intoMarwes:masterfrom
Conversation
Also added unit test to verify the impls work for types that don't implement PartialEq.
Marwes
approved these changes
Jun 16, 2021
Owner
Marwes
left a comment
Marwes
left a comment
There was a problem hiding this comment.
Thanks! I have fixed the CI build on master so if you rebase it should pass now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also added unit test to verify the impls work for types that don't implement PartialEq.
The specific use case I wanted to support was to run a parser on a SliceStream<proc_macro2::TokenTree>, but I believe the constraints I removed are just generally unnecessary.