Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipx installation failure fix #162

Merged
merged 2 commits into from
May 30, 2024

Conversation

rkollataj
Copy link
Contributor

After successful installation of demu_extended with pipx:

$ pipx install 'git+https://github.com/MarkHedleyJones/dmenu-extended'
  installed package dmenu_extended 1.2.1, installed using Python 3.12.3
  These apps are now globally available
    - dmenu_extended_cache_build
    - dmenu_extended_install_systemd_service
    - dmenu_extended_run

I am getting following error when running it:

$ dmenu_extended_run                                   
Traceback (most recent call last):
  File "/home/remol/.local/bin/dmenu_extended_run", line 5, in <module>
    from dmenu_extended.main import run
  File "/home/remol/.local/pipx/venvs/dmenu-extended/lib/python3.12/site-packages/dmenu_extended/__init__.py", line 1, in <module>
    from .main import *
  File "/home/remol/.local/pipx/venvs/dmenu-extended/lib/python3.12/site-packages/dmenu_extended/main.py", line 7, in <module>
    import pkg_resources
ModuleNotFoundError: No module named 'pkg_resources'

The fix adds missing dependency to pyproject.toml.

Signed-off-by: Remigiusz Kollataj <[email protected]>
@MarkHedleyJones
Copy link
Owner

@rkollataj Thanks for this update! The CI is failing as the version string in pyproject.toml needs updating to 1.2.2. Are you able to take care of that for me on your branch?

Signed-off-by: Remigiusz Kollataj <[email protected]>
@rkollataj
Copy link
Contributor Author

@MarkHedleyJones Just pushed incremented version. Hope it will be fine now :-)

@MarkHedleyJones MarkHedleyJones merged commit 9905ec4 into MarkHedleyJones:main May 30, 2024
1 check failed
@MarkHedleyJones
Copy link
Owner

@rkollataj So sorry for the delay. There are some issues in CI that need fixing, I'll force merge this for now and fix the issues after. Thank you very much for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants