Skip to content
/ server Public

MDEV-7394 : Making slave_skip_errors writable at runtime when slave is stopped #4634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mahmoud-kh1 wants to merge 2 commits into
base: main
Choose a base branch
from
+204 −83
Open

MDEV-7394 : Making slave_skip_errors writable at runtime when slave is stopped #4634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
440eec2
MDEV-7394 Make slave_skip_errors dynamic
Mahmoud-kh1 Feb 8, 2026
8ac6d7b
Merge branch 'main' into dynamic-slave-skip-error
Mahmoud-kh1 Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions mysql-test/suite/rpl/r/rpl_skip_error_dynamic.result
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
# MDEV-7394 test dynamic slave_skip_errors (writable when slaves stopped)
include/master-slave.inc
[connection master]
connection master;
CREATE TABLE t1 (id INT PRIMARY KEY);
include/sync_slave_sql_with_master.inc
connection slave;
INSERT INTO t1 VALUES (2);
connection master;
INSERT INTO t1 VALUES (2);
connection slave;
SET GLOBAL slave_skip_errors = "1062";
ERROR HY000: This operation cannot be performed as you have a running slave ''; run STOP SLAVE '' first
STOP SLAVE;
SET GLOBAL slave_skip_errors = "1062";
SELECT @@global.slave_skip_errors;
@@global.slave_skip_errors
1062
START SLAVE;
include/wait_for_slave_to_start.inc
connection master;
INSERT INTO t1 VALUES (3);
include/sync_slave_sql_with_master.inc
connection slave;
SELECT COUNT(*) FROM t1 WHERE id=3;
COUNT(*)
1
STOP SLAVE;
SET GLOBAL slave_skip_errors = "OFF";
START SLAVE;
connection master;
DROP TABLE t1;
include/sync_slave_sql_with_master.inc
include/rpl_end.inc
41 changes: 41 additions & 0 deletions mysql-test/suite/rpl/t/rpl_skip_error_dynamic.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
--echo # MDEV-7394 test dynamic slave_skip_errors (writable when slaves stopped)

--source include/master-slave.inc

connection master;
CREATE TABLE t1 (id INT PRIMARY KEY);
--source include/sync_slave_sql_with_master.inc

connection slave;
INSERT INTO t1 VALUES (2);

connection master;
INSERT INTO t1 VALUES (2);

connection slave;
--error ER_SLAVE_MUST_STOP
SET GLOBAL slave_skip_errors = "1062";

STOP SLAVE;
SET GLOBAL slave_skip_errors = "1062";
SELECT @@global.slave_skip_errors;
START SLAVE;
--source include/wait_for_slave_to_start.inc


connection master;
INSERT INTO t1 VALUES (3);
--source include/sync_slave_sql_with_master.inc

connection slave;
SELECT COUNT(*) FROM t1 WHERE id=3;

STOP SLAVE;
SET GLOBAL slave_skip_errors = "OFF";
START SLAVE;

connection master;
DROP TABLE t1;
--source include/sync_slave_sql_with_master.inc

--source include/rpl_end.inc
2 changes: 1 addition & 1 deletion mysql-test/suite/sys_vars/r/sysvars_server_notembedded.result
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4360,7 +4360,7 @@ NUMERIC_MIN_VALUE NULL
NUMERIC_MAX_VALUE NULL
NUMERIC_BLOCK_SIZE NULL
ENUM_VALUE_LIST NULL
READ_ONLY YES
READ_ONLY NO
COMMAND_LINE_ARGUMENT REQUIRED
VARIABLE_NAME SLAVE_SQL_VERIFY_CHECKSUM
VARIABLE_SCOPE GLOBAL
Expand Down
Loading