MDEV-35701 trx_t::autoinc_locks causes unnecessary dynamic memory allocation #3720
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
trx_t::autoinc_locks
: Usesmall_vector<lock_t*,4>
in order to avoid any dynamic memory allocation in the most common case (a statement is holdingAUTO_INCREMENT
locks on at most 4 tables or partitions).lock_cancel_waiting_and_release()
: Instead of removing elements from the middle, simply assignnullptr
, likelock_table_remove_autoinc_lock()
.Release Notes
This is a minor performance improvement.
How can this PR be tested?
A simple Sysbench is expected to show some impact. I did not test this yet.
Basing the PR against the correct MariaDB version
main
branch.PR quality check