Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dex swap fees #1252

Open
wants to merge 23 commits into
base: manta
Choose a base branch
from
Open

Dex swap fees #1252

wants to merge 23 commits into from

Conversation

ghzlatarev
Copy link
Contributor

@ghzlatarev ghzlatarev commented Aug 29, 2023

Description

  • Add a 0.5% fee for swaps where the asset-in is the native asset of the chain.
  • Add a test and update benchmarks
  • upstream code change: Dex swap fees Zenlink#1

Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.
  • Add A-integration-test-checks to run start-integration-test-checks (Required)
  • Add A-benchmark-checks to run start-benchmark-check (Required)
  • Add A-unit-test-checks to run start-unit-test-checks (Required)
  • Add A-congestion-test-checks to run start-integration-test-checks (Optional)

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Georgi Zlatarev <[email protected]>
@ghzlatarev ghzlatarev added A-manta Area: Issues and PRs related to the Manta Runtime A-calamari Area: Issues and PRs related to the Calamari Runtime A-runtime Area: Issues and PRs related to Runtimes A-benchmark-checks A-integration-test-checks A-unit-test-checks L-added Log: Issues and PRs related to addition C-discussion Category: Discussion or questions that don't represent real issues labels Aug 29, 2023
@ghzlatarev ghzlatarev marked this pull request as ready for review August 30, 2023 11:30
@ghzlatarev ghzlatarev requested review from zqhxuyuan, Dengjianping, Garandor and ferrell-code and removed request for Garandor August 30, 2023 11:30
Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented on zenlink branch

Signed-off-by: Georgi Zlatarev <[email protected]>
@ghzlatarev ghzlatarev requested a review from a team as a code owner August 31, 2023 02:15
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
ferrell-code
ferrell-code previously approved these changes Sep 1, 2023
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-benchmark-checks A-integration-test-checks A-manta Area: Issues and PRs related to the Manta Runtime A-runtime Area: Issues and PRs related to Runtimes A-unit-test-checks C-discussion Category: Discussion or questions that don't represent real issues L-added Log: Issues and PRs related to addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants