-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dex swap fees #1252
Open
ghzlatarev
wants to merge
23
commits into
manta
Choose a base branch
from
ghzlatarev/dex-swap-fees
base: manta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dex swap fees #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Georgi Zlatarev <[email protected]>
ghzlatarev
added
A-manta
Area: Issues and PRs related to the Manta Runtime
A-calamari
Area: Issues and PRs related to the Calamari Runtime
A-runtime
Area: Issues and PRs related to Runtimes
A-benchmark-checks
A-integration-test-checks
A-unit-test-checks
L-added
Log: Issues and PRs related to addition
C-discussion
Category: Discussion or questions that don't represent real issues
labels
Aug 29, 2023
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
ghzlatarev
requested review from
zqhxuyuan,
Dengjianping,
Garandor and
ferrell-code
and removed request for
Garandor
August 30, 2023 11:30
Signed-off-by: Georgi Zlatarev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commented on zenlink branch
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
ghzlatarev
removed
A-calamari
Area: Issues and PRs related to the Calamari Runtime
A-benchmark-checks
A-integration-test-checks
A-unit-test-checks
labels
Aug 31, 2023
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
ferrell-code
previously approved these changes
Sep 1, 2023
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-benchmark-checks
A-integration-test-checks
A-manta
Area: Issues and PRs related to the Manta Runtime
A-runtime
Area: Issues and PRs related to Runtimes
A-unit-test-checks
C-discussion
Category: Discussion or questions that don't represent real issues
L-added
Log: Issues and PRs related to addition
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before we can approve this PR for merge, please make sure that all the following items have been checked off:
L-
group to this PRA-
andC-
groups to this PRA-calamari
and/orA-manta
if your changes are meant for/impact either of these (CI depends on it)Files changed
in the Github PR explorer.A-integration-test-checks
to run start-integration-test-checks (Required)A-benchmark-checks
to run start-benchmark-check (Required)A-unit-test-checks
to run start-unit-test-checks (Required)A-congestion-test-checks
to run start-integration-test-checks (Optional)Situational Notes:
BaseFilter
. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime
. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]
items to check for any.