Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: Don't let user provide min_balance or is_sufficient as parameters to update_asset_metadata #1062

Open
wants to merge 4 commits into
base: manta
Choose a base branch
from

Conversation

Garandor
Copy link
Contributor

@Garandor Garandor commented Apr 4, 2023

Description

Alternative 2 (see #1059) - prevent changing these


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

@Garandor Garandor changed the title wip: User can not provide min_balance or is_sufficient as parameters to update_asset_metadata wip: Don't let user provide min_balance or is_sufficient as parameters to update_asset_metadata Apr 4, 2023
@Garandor Garandor requested a review from bhgomes April 4, 2023 04:03
@Garandor Garandor self-assigned this Apr 4, 2023
@Garandor Garandor added C-enhancement Category: An issue proposing an enhancement or a PR with one A-manta Area: Issues and PRs related to the Manta Runtime A-calamari Area: Issues and PRs related to the Calamari Runtime A-dolphin Area: Issues and PRs related to the Dolphin Runtime L-changed Log: Issues and PRs related to changes labels Apr 11, 2023
@Garandor Garandor marked this pull request as ready for review April 11, 2023 21:40
)?;
AssetIdMetadata::<T>::insert(asset_id, &metadata);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests are passing but I'm 90% sure it's not safe to skip this insert. The Assets metadata got updated above and it never seems to be used from here (not sure why we store the AssetStorageMetadata anyway since we never do anything with it outside of Assets code) but frontend code might depend on asset_id_metadata returning the correct values somewhere

The interface has no mutators unfortunately, so not sure how to update the field otherwise

Signed-off-by: Adam Reif <[email protected]>
@github-actions
Copy link

github-actions bot commented Apr 12, 2023

⚠️ Congestion test: 1-day congestion cost (calamari) is NOT above target_daily_congestion_cost_kma

@Garandor Garandor removed the request for review from bhgomes May 4, 2023 20:59
@Garandor Garandor removed their assignment Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-dolphin Area: Issues and PRs related to the Dolphin Runtime A-manta Area: Issues and PRs related to the Manta Runtime C-enhancement Category: An issue proposing an enhancement or a PR with one L-changed Log: Issues and PRs related to changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant