-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: Don't let user provide min_balance
or is_sufficient
as parameters to update_asset_metadata
#1062
base: manta
Are you sure you want to change the base?
Conversation
Signed-off-by: Adam Reif <[email protected]>
min_balance
or is_sufficient
as parameters to update_asset_metadata
min_balance
or is_sufficient
as parameters to update_asset_metadata
)?; | ||
AssetIdMetadata::<T>::insert(asset_id, &metadata); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests are passing but I'm 90% sure it's not safe to skip this insert. The Assets
metadata got updated above and it never seems to be used from here (not sure why we store the AssetStorageMetadata
anyway since we never do anything with it outside of Assets
code) but frontend code might depend on asset_id_metadata
returning the correct values somewhere
The interface has no mutators unfortunately, so not sure how to update the field otherwise
Signed-off-by: Adam Reif <[email protected]>
|
Description
Alternative 2 (see #1059) - prevent changing these
Before we can approve this PR for merge, please make sure that all the following items have been checked off:
L-
group to this PRA-
andC-
groups to this PRA-calamari
,A-dolphin
and/orA-manta
if your changes are meant for/impact either of these (CI depends on it)Files changed
in the Github PR explorer.Situational Notes:
BaseFilter
. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime
. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]
items to check for any.