Remove task_id from AE deliver_queue #23239
Merged
+1
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nasark unrecognized command 'assign_labels', ignoring... Accepted commands are: add_label, add_reviewer, request_review, assign, close_issue, cross_repo_test, move_issue, remove_label, rm_label, remove_reviewer, set_milestone, unassign |
|
@miq-bot add_labels bug, radjabov/yes? |
|
Checked commit nasark@2c83bef with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
agrare
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
LGTM, the only other caller of MiqAeEngine.deliver_queue explicitly nil's out the task_id
https://github.com/search?q=org%3AManageIQ%20MiqAeEngine.deliver_queue&type=code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task_idmay not be necessary with AE. This can cause issues in the event that there are multiple items in the queue with the sametask_id@miq-bot assign @Fryguy
@miq-bot add_reviewers @agrare, @Fryguy
@miq-bot assign_labels bug, radjabov/yes?