upgrade Factorybot to ruby3.3 friendly version #23234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot cross-repo-test /all |
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Oct 15, 2024
From Pull Request: ManageIQ/manageiq#23234
|
confused that this is red locally. though cross repo failed with workflow/ kicking |
|
ok, looks like there is a sporadic build for Ems. Will keep my eye open for that. |
|
kicking - workflows failed |
Related to ManageIQ/manageiq-providers-workflows#118 These factories were added: ManageIQ#22316 But were removed: ManageIQ#22503 They were basically NO-OP factories, so removing is no big deal For some reason, older versions of FactoryBot were ok with a bad reference (probably because the klass was overridden anyway) But newer versions of FactoryBot complained
|
update:
|
|
Checked commits kbrock/manageiq@9f5f225~...a4ea62f with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends upon:
(reference to bad factory was failing a cross repo)