Skip to content

Conversation

@SimonDanisch
Copy link
Member

No description provided.

@github-project-automation github-project-automation bot moved this to Work in progress in PR review Apr 23, 2025
@SimonDanisch SimonDanisch mentioned this pull request Apr 23, 2025
@SimonDanisch SimonDanisch added the skip-changelog Skips changelog enforcer label Apr 23, 2025
@MakieBot
Copy link
Collaborator

MakieBot commented Apr 23, 2025

Benchmark Results

SHA: 2c2f553abd31fd62e30ba161af6804f9ce0448f1

Warning

These results are subject to substantial noise because GitHub's CI runs on shared machines that are not ideally suited for benchmarking.

GLMakie
CairoMakie
WGLMakie

@SimonDanisch
Copy link
Member Author

image

Welp.... Seems like #4935 and #4879 fail independently ... Or its one more reference test that pushes it over some limit? The memory leak tests seem fine though, and the logs also look good, besides a few warnings that have been there before.

@SimonDanisch
Copy link
Member Author

Since both PRs add new shapes to the texture atlas, and at some point #4879 failed with blank for anything texture atlas related.

@ffreyer
Copy link
Collaborator

ffreyer commented Apr 28, 2025

My change reduces padding from 12px to 6px for the WGLMakie atlas, which should stop it from filling up faster than GLMakie's atlas. I uploaded a v8 atlas with the adjusted padding. If texture atlas overflow is the problem with tests they should pass now. But the issue is bound to return until we allow it to grow dynamically and/or split it by fonts and/or purpose (text vs scatter)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Skips changelog enforcer

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

4 participants