-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flutter_local_notifications] AndroidFlutterLocalNotificationsPlugin
Consume selected notification
#2212
base: master
Are you sure you want to change the base?
Conversation
…otificationLaunchApp`
…on-always-true Fix/launched from notification always true
LGTM BUMP! |
Not sure if you sure this but a similar had already been raised at #2150 though your one is conveys what it does more clearly. With that in mind, I believe what I wrote #2150 (comment) applies here too. Let me know what you think about changing how your PR works to match what I mentioned there |
Hi @MaikuB , I believe your comment may not directly apply to this PR. We have designed the functionality to be opt-in, requiring an explicit call to If this method does not meet your expectations, we propose an alternative: instead of omitting the notification when I understand that a similar concern was raised in issue #2150. However, this PR seeks to more clearly define the implementation. Reflecting on your insights shared in #2150 (comment), could you please provide your feedback on adjusting this PR to reflect those suggestions? |
@bitsydarel it applies to this PR as well as they both try to solve the same problem. What I'm referring to would also allow for an opt-in and the "cause" of this issue is developers have had assumptions before upon calling the As there have been these expectations before, what I'm proposing is something similar to what you're saying but it's not based on updating the response and it also retains the opt-in behaviour. If you look at what I wrote in #2150 (comment), I had described the proposal already. This was about updating the |
Sets an extra to Android intent which indicates that selected
notification has been consumed.
The feature is a fix of the issue: #1926