added permission check when using alarmClock as schedule mode (#2250)

* added permission check when using alarmClock as schedule mode * bumped device_info_plus dependency * remove steps to build using Flutter 3.0.0 * addressed unnecessary_set_literal warnings
MaikuB · Mar 5, 2024 · 1acce02 · 1acce02
1 parent 2783939
commit 1acce02
Show file tree

Hide file tree

Showing 8 changed files with 660 additions and 490 deletions.
diff --git a/.github/workflows/validate.yml b/.github/workflows/validate.yml
@@ -42,21 +42,6 @@ jobs:
         run: ./.github/workflows/scripts/install-tools.sh
       - name: Build
         run: melos run build:example_android
-  build_example_android_300:
-    name: Build Android example app (3.0.0)
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-      - uses: subosito/flutter-action@v2
-        with:
-          flutter-version: 3.0.0
-          channel: stable
-          cache: true
-          cache-key: 'flutter-:os:-:channel:-:version:-:arch:-:hash:'
-      - name: Install Tools
-        run: ./.github/workflows/scripts/install-tools.sh
-      - name: Build
-        run: melos run build:example_android
   build_example_ios_stable:
     name: Build iOS example app (stable channel)
     runs-on: macos-latest
@@ -103,25 +88,6 @@ jobs:
       - run: flutter config --enable-linux-desktop
       - name: Build
         run: melos run build:example_linux
-  build_example_linux_300:
-    name: Build Linux example app (3.0.0)
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-      - uses: subosito/flutter-action@v2
-        with:
-          flutter-version: 3.0.0
-          channel: stable
-          cache: true
-          cache-key: 'flutter-:os:-:channel:-:version:-:arch:-:hash:'
-      - name: Install Tools
-        run: ./.github/workflows/scripts/install-tools.sh
-      - run: |
-          sudo apt-get update -y
-          sudo apt-get install -y ninja-build libgtk-3-dev
-      - run: flutter config --enable-linux-desktop
-      - name: Build
-        run: melos run build:example_linux
   unit_tests_dart:
     name: Run all unit tests (Dart)
     runs-on: ubuntu-latest

diff --git a/flutter_local_notifications/CHANGELOG.md b/flutter_local_notifications/CHANGELOG.md
@@ -1,3 +1,8 @@
+# [16.3.3]
+
+* [Android] added missing check on if `SCHEDULE_EXACT_ALARM` permission was granted when using the `alarmClock` as the `AndroidScheduleMode`
+* Bumped `device_info_plus` dependency for example app, which means example app requires Flutter SDK version 3.3.0 or higher to run
+
 # [16.3.2]
 
 * [Android] fixed how native stack traces were obtained. Relates to issue [2088](https://github.com/MaikuB/flutter_local_notifications/issues/2088). Thanks to the PR from [Jonas Uekötter](https://github.com/ueman)

diff --git a/...rc/main/java/com/dexterous/flutterlocalnotifications/FlutterLocalNotificationsPlugin.java b/...rc/main/java/com/dexterous/flutterlocalnotifications/FlutterLocalNotificationsPlugin.java
@@ -717,6 +717,7 @@ private static void setupAlarm(
         AlarmManagerCompat.setExact(
             alarmManager, AlarmManager.RTC_WAKEUP, epochMilli, pendingIntent);
       } else if (notificationDetails.scheduleMode.useAlarmClock()) {
+        checkCanScheduleExactAlarms(alarmManager);
         AlarmManagerCompat.setAlarmClock(alarmManager, epochMilli, pendingIntent, pendingIntent);
       } else {
         alarmManager.set(AlarmManager.RTC_WAKEUP, epochMilli, pendingIntent);
@@ -734,6 +735,7 @@ private static void setupAllowWhileIdleAlarm(
       AlarmManagerCompat.setExactAndAllowWhileIdle(
           alarmManager, AlarmManager.RTC_WAKEUP, epochMilli, pendingIntent);
     } else if (notificationDetails.scheduleMode.useAlarmClock()) {
+      checkCanScheduleExactAlarms(alarmManager);
       AlarmManagerCompat.setAlarmClock(alarmManager, epochMilli, pendingIntent, pendingIntent);
     } else {
       AlarmManagerCompat.setAndAllowWhileIdle(

diff --git a/flutter_local_notifications/example/lib/main.dart b/flutter_local_notifications/example/lib/main.dart
diff --git a/flutter_local_notifications/example/pubspec.yaml b/flutter_local_notifications/example/pubspec.yaml
@@ -4,7 +4,7 @@ publish_to: none
 
 dependencies:
   cupertino_icons: ^1.0.2
-  device_info_plus: ^8.0.0
+  device_info_plus: ^9.1.2
   flutter:
     sdk: flutter
   flutter_local_notifications:

diff --git a/flutter_local_notifications/pubspec.yaml b/flutter_local_notifications/pubspec.yaml
@@ -2,7 +2,7 @@ name: flutter_local_notifications
 description: A cross platform plugin for displaying and scheduling local
   notifications for Flutter applications with the ability to customise for each
   platform.
-version: 16.3.2
+version: 16.3.3
 homepage: https://github.com/MaikuB/flutter_local_notifications/tree/master/flutter_local_notifications
 issue_tracker: https://github.com/MaikuB/flutter_local_notifications/issues
 

diff --git a/flutter_local_notifications_linux/test/notifications_manager_test.dart b/flutter_local_notifications_linux/test/notifications_manager_test.dart
@@ -65,13 +65,13 @@ void main() {
       ).thenAnswer((_) async => platformInfo);
       when(
         mockStorage.forceReloadCache(),
-      ).thenAnswer((_) async => <void>{});
+      ).thenAnswer((_) async {});
       when(
         mockDbus.build(
           destination: 'org.freedesktop.Notifications',
           path: '/org/freedesktop/Notifications',
         ),
-      ).thenAnswer((_) => <void>{});
+      ).thenAnswer((_) {});
       when(
         mockDbus.subscribeSignal('ActionInvoked'),
       ).thenAnswer((_) => mockActionInvokedSignal);

diff --git a/flutter_local_notifications_linux/test/storage_test.dart b/flutter_local_notifications_linux/test/storage_test.dart
@@ -75,10 +75,10 @@ void main() {
       when(mockStorageFile.existsSync()).thenReturn(false);
       when(
         mockStorageFile.createSync(recursive: true),
-      ).thenAnswer((_) => <void>{});
+      ).thenAnswer((_) {});
       when(
         mockStorageFile.writeAsStringSync(any),
-      ).thenAnswer((_) => <void>{});
+      ).thenAnswer((_) {});
       when(mockStorageFile.readAsStringSync()).thenReturn('');
 
       expect(await storage.insert(notifications[0]), isTrue);
@@ -111,7 +111,7 @@ void main() {
       when(mockStorageFile.existsSync()).thenReturn(true);
       when(
         mockStorageFile.writeAsStringSync(any),
-      ).thenAnswer((_) => <void>{});
+      ).thenAnswer((_) {});
       when(mockStorageFile.readAsStringSync()).thenReturn('');
 
       await storage.insert(notifications[0]);
@@ -153,7 +153,7 @@ void main() {
       when(mockStorageFile.existsSync()).thenReturn(true);
       when(
         mockStorageFile.writeAsStringSync(any),
-      ).thenAnswer((_) => <void>{});
+      ).thenAnswer((_) {});
 
       when(mockStorageFile.readAsStringSync()).thenReturn('');
       expect(await storage.getAll(), <LinuxNotificationInfo>[]);
@@ -185,7 +185,7 @@ void main() {
       when(mockStorageFile.existsSync()).thenReturn(true);
       when(
         mockStorageFile.writeAsStringSync(any),
-      ).thenAnswer((_) => <void>{});
+      ).thenAnswer((_) {});
 
       when(mockStorageFile.readAsStringSync()).thenReturn('');
       expect(await storage.getAll(), <LinuxNotificationInfo>[]);
@@ -213,7 +213,7 @@ void main() {
       when(mockStorageFile.existsSync()).thenReturn(true);
       when(
         mockStorageFile.writeAsStringSync(any),
-      ).thenAnswer((_) => <void>{});
+      ).thenAnswer((_) {});
 
       when(
         mockStorageFile.readAsStringSync(),
@@ -241,7 +241,7 @@ void main() {
       when(mockStorageFile.existsSync()).thenReturn(true);
       when(
         mockStorageFile.writeAsStringSync(any),
-      ).thenAnswer((_) => <void>{});
+      ).thenAnswer((_) {});
       when(mockStorageFile.readAsStringSync()).thenReturn('');
 
       await storage.insert(notifications[0]);
@@ -271,7 +271,7 @@ void main() {
       when(mockStorageFile.existsSync()).thenReturn(true);
       when(
         mockStorageFile.writeAsStringSync(any),
-      ).thenAnswer((_) => <void>{});
+      ).thenAnswer((_) {});
       when(mockStorageFile.readAsStringSync()).thenReturn('');
 
       await storage.insert(notification);