Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save Username in Local Storage only at Permission #228

Merged
merged 10 commits into from
Jan 15, 2024

Conversation

Nomandes
Copy link
Contributor

@Nomandes Nomandes commented Jan 8, 2024

Save Username in Local Storage only at Permission

Issue: #225

Acceptance Criteria

  • When entering a room, a checkbox with a label "Persist username" is visible
  • Hovering the checkbox and label shows a explanation text
  • The checkbox is initially unchecked
  • The checkbox state is persisted in local storage
  • The checkbox state in local storage is applied at future sessions
  • When the checkbox is checked, the username is persisted in local storage

Description

The local storage of the username is now only applied if the checkbox is checked. The state handling was extracted in its own hook and the textfield with checkbox in its own module to be reused in the create session and join session dialogs.

@Nomandes Nomandes added the feature New feature or request label Jan 8, 2024
@Nomandes Nomandes requested a review from NearW January 8, 2024 14:23
@NearW
Copy link
Collaborator

NearW commented Jan 9, 2024

Tested it locally: Works fine :)

@Nomandes Nomandes requested a review from NearW January 9, 2024 09:51
@Nomandes Nomandes requested a review from NearW January 15, 2024 10:16
@Nomandes Nomandes merged commit 5869c4d into master Jan 15, 2024
1 check passed
@Nomandes Nomandes deleted the feature/local_storage_permission branch January 15, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants