clang-tidy fix

Mag1str02 · Jan 13, 2025 · 0844b83 · 0844b83
1 parent db92c1f
commit 0844b83
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/DummyEngine/Core/Application/Window.cpp b/DummyEngine/Core/Application/Window.cpp
@@ -10,7 +10,7 @@ namespace DummyEngine {
     GLFWmonitor* GetMonitor(U32 id) {
         int           monitors_amount = 0;
         GLFWmonitor** monitors        = glfwGetMonitors(&monitors_amount);
-        DE_ASSERT(id < U32(monitors_amount), "Wrong monitor id {} should be between [0, {})", id, monitors_amount); // id >= 0 because of unsigned int
+        DE_ASSERT(id < U32(monitors_amount), "Wrong monitor id {} should be between [0, {})", id, monitors_amount);
         return monitors[id];
     }
 

diff --git a/DummyEngine/Core/Console/ConsoleLayer.hpp b/DummyEngine/Core/Console/ConsoleLayer.hpp
@@ -16,7 +16,7 @@ namespace DummyEngine {
     private:
         bool        show_ = false;
         std::string command_;
-        S32         history_position_ = 0; // signed, for possibility for -1 in runtime
+        S32         history_position_ = 0;
         bool        scroll_to_bottom_ = true;
         bool        just_opened_      = false;
     };

diff --git a/DummyEngine/Core/Rendering/Renderer/BufferLayout.cpp b/DummyEngine/Core/Rendering/Renderer/BufferLayout.cpp
@@ -113,7 +113,7 @@ namespace DummyEngine {
         return elements_.end();
     }
     const BufferElement& BufferLayout::operator[](U32 index) const {
-        DE_ASSERT(index < elements_.size(), "Index out of bounce {} should be between [0,{})", index, elements_.size()); // already >= 0 because of U32
+        DE_ASSERT(index < elements_.size(), "Index out of bounce {} should be between [0,{})", index, elements_.size());
         return elements_[index];
     }
 

diff --git a/DummyEngine/Core/Rendering/RendererOpenGL/GLFrameBuffer.cpp b/DummyEngine/Core/Rendering/RendererOpenGL/GLFrameBuffer.cpp
@@ -105,7 +105,7 @@ namespace DummyEngine {
     }
 
     Ref<Texture> GLFrameBuffer::GetColorAttachment(U32 attachment_id = 0) {
-        DE_ASSERT(attachment_id < color_attachments_.size(), "Color attachment with index {} does not exist", attachment_id); // already >= 0, because of U32
+        DE_ASSERT(attachment_id < color_attachments_.size(), "Color attachment with index {} does not exist", attachment_id);
         return color_attachments_[attachment_id].Texture;
     }
     Ref<Texture> GLFrameBuffer::GetDepthAttachment() {