add MPCSolver with proper data structure #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amontoison
reviewed
Apr 30, 2025
src/kernels.jl
Outdated
| return | ||
| end | ||
|
|
||
| function set_corrective_rhs!(solver::MadNLP.AbstractMadNLPSolver, kkt::MadNLP.AbstractKKTSystem, mu::Float64, correction_lb::Vector{Float64}, correction_ub::Vector{Float64}, ind_lb, ind_ub) |
Member
There was a problem hiding this comment.
Suggested change
| function set_corrective_rhs!(solver::MadNLP.AbstractMadNLPSolver, kkt::MadNLP.AbstractKKTSystem, mu::Float64, correction_lb::Vector{Float64}, correction_ub::Vector{Float64}, ind_lb, ind_ub) | |
| function set_correction_rhs!(solver::MadNLP.AbstractMadNLPSolver, kkt::MadNLP.AbstractKKTSystem, mu::Float64, correction_lb::Vector{Float64}, correction_ub::Vector{Float64}, ind_lb, ind_ub) |
Member
There was a problem hiding this comment.
We can be consistent with the other routines if we do this modification.
amontoison
reviewed
Apr 30, 2025
| end | ||
|
|
||
| # Predictor-corrector method | ||
| function mpc!(solver::MadNLP.AbstractMadNLPSolver; max_ncorr=0) |
Member
There was a problem hiding this comment.
I suppose that max_ncorr was for the multiple corrections variant of Gondzio but not implemented?
Member
Author
There was a problem hiding this comment.
max_ncorr has been moved in the structure IPMOptions. Gondzio's multiple corrections have been implemented already :)
amontoison
approved these changes
Apr 30, 2025
Member
amontoison
left a comment
amontoison
left a comment
There was a problem hiding this comment.
Except two small details, LGTM 👍
Thanks François!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.