Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up pre-commit hooks #2283

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

afuetterer
Copy link
Contributor

What does this PR do?

Fixes #2274

I used the same config like the KeyBERT repo, but updated the hooks versions. Should the extra lint ci job be removed? I did not want to remove it without asking for permission.

This now leads to a lot of "trailing whitespace" fixes. Also there are a few findings from ruff.

Do you want (me) to fix those in this PR?

Before submitting

  • This PR fixes a typo or improves the docs (if yes, ignore all other checks!).
  • Did you read the contributor guideline?
  • Was this discussed/approved via a Github issue? Please add a link to it if that's the case.
  • Did you make sure to update the documentation with your changes (if applicable)?
  • Did you write any new necessary tests?

@afuetterer
Copy link
Contributor Author

For comparison: The lint step using the pre-commit hooks (without installing BERTopic itself) took 22 seconds, whereas the lint job (with installing BERTopic and dev dependencies) took 3m 11s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up pre-commit hook(s)
1 participant