add automatic height scaling and font resize #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaartenGr
reviewed
Mar 15, 2024
There was a problem hiding this comment.
Thanks for the PR! I have one additional question. What happens when you want to have the compressed version still? It seems that this always forces large barcharts to be made if users have >12 words. However, I can imagine, and I am one of them, that they might prefer to have the original barcharts in some cases. For instance, I like the process of creating a more global perspective and zooming in when necessary.
|
Awesome, thanks for your work on this! LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tackles issue #1858. The issue is solved by scaling the font size up to 12 words. Starting from 12 words the words become slightly harder to read, so a slight height update for the figure is done.
Example for 10, 15, and 30 words: