feat: search both origin and canonicalized directory of current_exe
#94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In recent changes, we force `current_exe` to be canonicalized. However, for homebrew, `maa` is installed in separate directory, and linked to `/usr/local/bin/maa` or `/opt/homebrew/bin/maa`. To search library and resource also installed by homebrew, we need to search the origin directory of `current_exe`. So we search both origin and canonicalized directory of `current_exe`.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
==========================================
- Coverage 22.77% 22.68% -0.10%
==========================================
Files 20 20
Lines 1484 1490 +6
==========================================
Hits 338 338
- Misses 1146 1152 +6
☔ View full report in Codecov by Sentry. |
This was referenced Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In recent changes, we force
current_exeto be canonicalized. However, for homebrew,maais installed in separate directory, and linked to/usr/local/bin/maaor/opt/homebrew/bin/maa. To search library and resource also installed by homebrew, we need to search the origin directory ofcurrent_exe. So we search both origin and canonicalized directory ofcurrent_exe.