Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature added: KNITE:1239- Content will stay without getting rearranged when editor is resized #410

Open
wants to merge 32 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
3fc9b83
Build(deps-dev): Bump follow-redirects from 1.15.5 to 1.15.6
dependabot[bot] Mar 17, 2024
339392f
Merge pull request #261 from MO-Movia/dependabot/npm_and_yarn/follow-…
Tezra Mar 18, 2024
167314b
Build(deps-dev): Bump webpack-dev-middleware from 7.0.0 to 7.1.1
dependabot[bot] Mar 21, 2024
1a96964
Merge pull request #267 from MO-Movia/dependabot/npm_and_yarn/webpack…
Tezra Mar 24, 2024
8b7be5d
Build(deps): Bump the npm_and_yarn group across 1 directory with 2 up…
dependabot[bot] Mar 25, 2024
e8d8d64
Build(deps): Bump the npm_and_yarn group across 1 directory with 1 up…
dependabot[bot] Mar 25, 2024
49e5d71
Merge pull request #273 from MO-Movia/dependabot/npm_and_yarn/npm_and…
Tezra Mar 28, 2024
6bf0a33
Merge pull request #275 from MO-Movia/dependabot/npm_and_yarn/npm_and…
Tezra Mar 28, 2024
15229ba
Build(deps): Bump formidable
dependabot[bot] Apr 23, 2024
6b281ec
Merge pull request #296 from MO-Movia/dependabot/npm_and_yarn/npm_and…
Tezra Apr 29, 2024
9c08f7f
Merge branch 'develop'
May 7, 2024
5541a6b
Merge branch 'develop'
May 7, 2024
565513e
Merge branch 'develop'
May 7, 2024
bcbe18e
Build(deps-dev): Bump the npm_and_yarn group across 1 directory with …
dependabot[bot] Jun 18, 2024
8da6728
Merge pull request #333 from MO-Movia/dependabot/npm_and_yarn/npm_and…
Tezra Jun 19, 2024
88a39ef
Build(deps-dev): Bump webpack
dependabot[bot] Aug 31, 2024
b1bc329
Merge pull request #384 from MO-Movia/dependabot/npm_and_yarn/npm_and…
Tezra Sep 3, 2024
051b707
Build(deps): Bump the npm_and_yarn group across 1 directory with 2 up…
dependabot[bot] Sep 11, 2024
7be6908
Merge pull request #396 from MO-Movia/dependabot/npm_and_yarn/npm_and…
Tezra Sep 11, 2024
63ccf91
Fixed the issue that the backspace and enter key makes the selection …
Sep 19, 2024
a694e2f
Fixed the issue of edit button goes outside the vignette if vignette …
Sep 19, 2024
e3c31fa
Resolved the cursor issue in the scrollbar of vignette
Sep 19, 2024
e5e249c
KNITE - 1239 - The content in the editor shouldn’t get rearranged whe…
Sep 19, 2024
e1e19d0
synced with develop
Oct 4, 2024
85778cf
Merge remote-tracking branch 'origin/develop' into feature/KNITE-1239…
Oct 14, 2024
9094ddf
Merge branch 'develop' into feature/KNITE-1239-editor-width-resize
Tezra Oct 14, 2024
2a60fe5
Merge remote-tracking branch 'origin/main' into feature/KNITE-1239-ed…
Tezra Oct 14, 2024
eac1e23
update ver + lock
Tezra Oct 14, 2024
d3bf9ab
fix lint issues
Tezra Oct 14, 2024
e96af2b
Fixed unit test issue by downgrading the typescript version
Oct 25, 2024
d21b852
typescript update for jest
rohanrjohn Oct 29, 2024
50629a2
lock updated with typescript version update
rohanrjohn Oct 29, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
"eslint-plugin-react": "^7.33.2",
"exports-loader": "^5.0.0",
"file-loader": "^6.2.0",
"flow-bin": "^0.245.2",
"flow-bin": "^0.247.1",
"flow-copy-source": "^2.0.9",
"flow-webpack-plugin": "^1.2.0",
"html-loader": "^5.0.0",
Expand Down
3 changes: 0 additions & 3 deletions src/client/Licit.js
Original file line number Diff line number Diff line change
Expand Up @@ -366,9 +366,6 @@ class Licit extends React.Component<any, any> {
// Reset lastKeyCode since the content is set dynamically and so lastKeyCode is invalid now.
this._editorView.lastKeyCode = null;

const selection = TextSelection.create(doc, 0, doc.content.size);

tr = tr.setSelection(selection).replaceSelectionWith(document, false);
// [FS] IRAD-1092 2020-12-03
// set the value for object metadata and objectId
// Should update all document attributes.
Expand Down
2 changes: 1 addition & 1 deletion src/ui/czi-editor.css
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@
box-shadow: unset;
min-height: unset;
padding: unset;
width: unset;
width: 78vw;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be 100%? It should fill the parent container. This looks like it would break the comments ui.

}

@media only print {
Expand Down
4 changes: 3 additions & 1 deletion src/ui/czi-table-cell-menu.css
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
.czi-table-cell-menu.use-icon {
position: fixed;
margin-left: -26px;
margin-top: 5px;
box-shadow: 0 0 0 0.3px rgba(0, 0, 0, 0.35);
font-size: 12px;
font-weight: normal;
height: 20px;
line-height: 22px;
margin: 5px 5px 0 0;
text-align: center;
width: 20px;
}
Expand Down
1 change: 1 addition & 0 deletions src/ui/czi-table.css
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

.ProseMirror .tableWrapper {
overflow-x: auto;
cursor: default;
}
.ProseMirror .tableWrapper::-webkit-scrollbar{
height: 12px;
Expand Down