Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair include #1247

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Repair include #1247

merged 2 commits into from
Jul 26, 2024

Conversation

qha
Copy link
Contributor

@qha qha commented Jun 28, 2024

Include docs, examples and tests in sdist

Merging this would probably mean that i can use the tar.gz from pypi directly and still get tests without rolling my own.

@Rafiot
Copy link
Member

Rafiot commented Jun 28, 2024

Just making sure before I merge it: did you test it and it works for you?

@qha
Copy link
Contributor Author

qha commented Jun 28, 2024

I added { path = "tests", format = "sdist" } and ran python3 -m build --sdist . and it had the effect i expected on the produced tarball, i didn't test building a wheel from it though.

@qha qha changed the title Repair include Draft: Repair include Jul 3, 2024
@qha qha marked this pull request as draft July 3, 2024 14:02
@qha
Copy link
Contributor Author

qha commented Jul 3, 2024

I've now completed my entire packaging including running pytest tests/test_mispevent.py after adjusting the include statement.

@qha qha marked this pull request as ready for review July 3, 2024 14:59
@qha qha changed the title Draft: Repair include Repair include Jul 3, 2024
@Rafiot Rafiot merged commit b5e5ea5 into MISP:main Jul 26, 2024
8 checks passed
@qha qha deleted the repair-include branch July 30, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants