Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected the error with CPO initial_volume #25

Open
wants to merge 1 commit into
base: add_drexpp
Choose a base branch
from

Conversation

srivatsvyas
Copy link

  1. Made the change discussed to line 194 regarding initial volume fraction. This is reflected in the CPO file output.
  2. Added an if else for pole deflection in line 99. Created a variable dt to store time of simulation in line 76. If dt = 0, then create a normal rotation matrix. If dt != 0, constrained the pole deflection to 0.1PIthree rather than 2PIthree. Did not test this as had problems with the output and piezometer addtion.
  3. Added both the piezometer and paleowattmeter in line-718.(just substituted the values in the equation for the paleowattmeter directly so will look messy, sorry :(! ). After making the change to the initial volume fraction, this part does not cause a floating point exception anymore but would be better to check from your side (I tried the paleopiezometer, dont feel comfortable deriving all the terms for the paleowattmeter yet, its there but am still a bit unsure for the equation works so didnt test it now).
  4. TO-DOs left: the threshold condition for discriminating dislocation creep and diffusion creep.

Copy link
Owner

@MFraters MFraters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

  1. So is the issue with the initial grain sizes being zero fixed?
  2. hmm, interesting approach. Did you check whether limits the rotation to 10 degrees? If it does, we can leave it for now, but it probably should become an input parameter for the function later.
  3. I actually think it is good to split up the equation into multiple parts and then combine them. please add a comment explaining the equation you are solving. Also, I doubt you need a long double for this. a normal double should be fine.
  4. I can take a look at that.

@@ -73,6 +73,7 @@ namespace aspect
CrystalPreferredOrientation<dim>::compute_random_rotation_matrix(Tensor<2,3> &rotation_matrix) const
{

const double dt = this -> get_time();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dt is usally used for a time difference, you can just call the variable time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants