-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite for version 2.0 #332
Conversation
Awesome! One thing I noticed is in Data Path view for some pair of registers, the bus transfer flows in the opposite direction, from write register to read register. For example, AC and IN registers. |
Looks good to me! Let me know if you want me to check specific parts of the features or the codebase. |
Switching between examples sometimes causes the whole screen to flash. |
I guess this is probably because of the loading animation - I forgot that on light mode it'll look like a really dark flash. I'll fix that next week before I merge this. |
src/project.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good if there is a function that imports marie-program
and saves it to marie.projects
in local storage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function will perform a data migration to MARIE.js v2.0, and any work that is saved in the browser will not be "lost" (technically it should still be in the browser, but will no longer be accessible).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I'll have a look at implementing that next week
For autocomplete, I think we can also have tab and right arrow key perform auto-complete in addition to pressing Enter. |
Quine example has a broken link for decompiled version. |
This is a new implementation of the simulator in TypeScript using Svelte.
Currently deployed here.
I think all the useful features from the old simulator are now implemented in the new one (hopefully).