Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite for version 2.0 #332

Merged
merged 21 commits into from
Jan 28, 2025
Merged

Rewrite for version 2.0 #332

merged 21 commits into from
Jan 28, 2025

Conversation

cyderize
Copy link
Collaborator

This is a new implementation of the simulator in TypeScript using Svelte.

Currently deployed here.

I think all the useful features from the old simulator are now implemented in the new one (hopefully).

@cyderize cyderize requested a review from auroranil as a code owner January 21, 2025 02:36
@auroranil
Copy link
Member

Awesome!

One thing I noticed is in Data Path view for some pair of registers, the bus transfer flows in the opposite direction, from write register to read register. For example, AC and IN registers.

src/lib/DataPath.svelte Outdated Show resolved Hide resolved
@auroranil
Copy link
Member

Looks good to me! Let me know if you want me to check specific parts of the features or the codebase.

auroranil
auroranil previously approved these changes Jan 25, 2025
@auroranil
Copy link
Member

Switching between examples sometimes causes the whole screen to flash.

@cyderize
Copy link
Collaborator Author

Switching between examples sometimes causes the whole screen to flash.

I guess this is probably because of the loading animation - I forgot that on light mode it'll look like a really dark flash. I'll fix that next week before I merge this.

src/project.ts Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good if there is a function that imports marie-program and saves it to marie.projects in local storage.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function will perform a data migration to MARIE.js v2.0, and any work that is saved in the browser will not be "lost" (technically it should still be in the browser, but will no longer be accessible).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I'll have a look at implementing that next week

ericjiang97
ericjiang97 previously approved these changes Jan 25, 2025
@auroranil
Copy link
Member

For autocomplete, I think we can also have tab and right arrow key perform auto-complete in addition to pressing Enter.

@auroranil
Copy link
Member

Quine example has a broken link for decompiled version.

@cyderize cyderize dismissed stale reviews from ericjiang97 and auroranil via c5ee75b January 27, 2025 22:57
@cyderize cyderize merged commit 7085e85 into MARIE-js:main Jan 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants