Fixes for launcher.config XML changes and version bump to 0.2.2 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old chain has been broken as of yesterday (01-13-2016) or possibly earlier.
Turbine has removed the client local files for each language. Now each language has a separate subdirectory. If the client local file is not found then I pick languages based on those subdirectories
With or without this, PyLotro in Lotro mode lists "English" twice, but without it PyLotro doesn't display news by default. I would very much welcome a better fix here.
Localization changes from hcjiv1 and Arek75
Python 3.x was throwing a UnicodeDecodeError when attempting to write turbine-supplied config files. This fixes that by opening the files in utf-8 mode.
The previous fix works fine on Python 3.x, but breaks on 2.x because of differences in unicode support. This change makes the fix so it is now only used when Python 3.x is in use.
That was embarrasing. I forgot to make sure that the 2 open functions had compatible signatures or that I was using them in a compatible way. My wrapper now fixes that, but doesn't expose the full functionality of open(), only what's used here.
Fix for unicode errors on Python 3.x for Windows
Update certificate chain.
Fix language list displaying non-languages in list.
…e.config in game directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On 20-Nov-2014 Turbine changed the format of launcher.config which broke pylotro functionality. On 15-Dec-2014 Update 15.1 also introduced more changes which broke pylotro again. Fixes tested and working fine.
See the following forum threads for more information:
https://www.lotro.com/forums/showthread.php?559349-Can-t-log-in-with-Linux-at-the-moment-anybody-else
https://www.lotro.com/forums/showthread.php?560728-For-Linux-users-Update-15-1-breaks-pylotro-again-fix-here