Slip button, tap tempo, strip search, FX button extras #1

eigengrau · 2018-04-09T17:06:41Z

Add support for slip button, tap tempo button, jog wheel strip search.

eigengrau · 2018-04-09T17:08:16Z

I was gonna reply to you on the forums for some additional discussion, but I’m still waiting for the activation mail. So here’s what I got for now.

Tap tempo is a bit unexpected, since Mixxx expects at least 8 taps before it will set the tempo. I was always tapping four and got unexpected results, so bear that in mind.

eigengrau · 2018-04-09T17:09:47Z

Incidentally, is there a specific reason the XML bindings are limited to deck 1? For consistency’s sake the commits also only add deck 1 for now.

Lykos153 · 2018-04-09T17:20:02Z

Thank's a lot! I hope I'll be able to look into it today or tomorrow.

Incidentally, is there a specific reason the XML bindings are limited to deck 1? For consistency’s sake the commits also only add deck 1 for now.

It was actually just laziness. I wanted to keep the XML file short while I was still experimenting with it, so I had to apply modifications only once. I was planning to just copy everything for the second deck when I'm finished.

Be-ing · 2018-04-09T20:30:01Z

Could one of you open a pull request for the upstream mixxxdj/mixxx repository? It's okay if the mapping is not complete yet, just put "[WIP]" (work in progress) in the title of the pull request. This will make it easier for other people to find the discussion.

Lykos153 · 2018-04-09T20:35:55Z

Done: mixxxdj#1595

eigengrau · 2018-04-10T16:24:17Z

Have some free commits!

I don’t usually do any JS, so any nits welcome.

Since the shift button applies both to the FX racks as well as the decks, the button is now a property of the controller instance. - Shift+FX₁{1…4} ⇒ Cycle selected effect - Shift+Level-knob ⇒ Control FX rack super knob

- Shift+Cue (“tap tempo”), short ⇒ tap tempo, align beat grid to play-back position - Shift+Cue (“tap tempo”), long ⇒ align beat grid to other deck

eigengrau · 2018-04-11T14:53:27Z

So, the two last commits are ideas I had on some behavior that isn’t directly labeled on the controller.

Beat grid (0bd482c)
1. This dual-binds the tap tempo button. Since I expect you’d normally tap BPM in sync with the beat, this will also align the beat grid with your tap. The caveat is that if you want to align the grid without tapping a new BPM, you need to wait 2 seconds until you can do it again, in order to not make it register as a BPM-tap. We might be able to improve this.
2. Long holding tap tempo will align the beat grid to the other deck.
Key shift (067e97f) – Since the key lock button is comfortably close to the param-buttons and is already associated with musical key, the idea is to long hold key lock and press up/down to shift musical key. Long hold and press both up/down together to reset the key.

Note that 067e97f also commits my current work-around for the Keylock-LED reset issue and doesn’t yet use the components framework. We could refactor that later if we want to keep this behavior.

WDYT?

eigengrau · 2018-04-11T15:27:36Z

res/controllers/Roland_DJ-202-scripts.js

@@ -62,6 +62,34 @@ DJ202.Deck = function (deckNumbers, offset) {
        },
    });

+    this.paramUp = function (channel, control, value, status, group) {


Since the MIDI control is supplied, paramUp and paramDown could probably be merged into one binding.

For now that's true. We'd probably have to rethink this in case we want to use them for layering the performance pads #5

eigengrau · 2018-04-11T18:09:12Z

Key shift (037cd2b) – Since the key lock button is comfortably close to the param-buttons and is already associated with musical key, the idea is to long hold key lock and press up/down to shift musical key. Long hold and press both up/down together to reset the key.

Actually, I failed to notice that the param buttons send another note when the pad section is in another state. So these should be bound, too. Edit: amended.

- Key-Lock (long) + Param{Up,Down} ⇒ Shift musical key - Key-Lock (long) + ParamUp + ParamDown ⇒ Reset musical key

As per the wiki, ‘SelectTrackKnob’ is deprecated.

• Push ⇒ Move focus forward • Shift+Push ⇒ Move focus backward

eigengrau · 2018-04-11T20:16:56Z

3b2e934 is a wart for now. Since components.SyncButton doesn’t have double tap, and since we need to fudge around with the LEDs, this brings in a lot of code that should be generalized and put somewhere else. Everything not related to the LEDs and double Tap is the same logic used in components.SyncButton.

• Sync-Button (double-tap) ⇒ Reset deck BPM to file BPM

Lykos153

nvm

Lykos153

nvm

Lykos153 · 2018-04-12T00:20:22Z

res/controllers/Roland_DJ-202.midi.xml

@@ -547,6 +547,15 @@
                    <script-binding/>
                </options>
            </control>
+            <control>
+                <group>[Channel1]</group>
+                <key>slip_enabled</key>


For our aim to stay as close as possible to the labeling, I would like to map this inside the script so we can have both vinyl/slip. We could add a variable like "invertVinylSlipButton" for the user to configure the default (unshifted) behaviour.

Lykos153 · 2018-04-12T00:23:49Z

res/controllers/Roland_DJ-202-scripts.js

+                script.triggerControl(group, isShifted ? 'ScrollDown' : 'MoveDown');
+            }
+            break;
+        case 0x9F: // Push.


Maybe we could add a way to open/close tree leaves. Eg. Push: Move focus
Shift+Push in tree view: Open leaf
Shift+Push in playlist view: Load track into preview deck

Or we could use the load buttons, as they're not used in the tree view.

Lykos153 · 2018-04-12T00:30:43Z

res/controllers/Roland_DJ-202-scripts.js

+                            this.isDoubleTap = false;
+                        }, true);
+                    } else {
+                        engine.setValue(this.group, 'sync_enabled', 0);


I just experienced a glitch after a double tap while sync was enabled. Can't reproduce it right now, so just leaving a note to maybe investigate this later.

Lykos153 · 2018-04-12T00:32:01Z

res/controllers/Roland_DJ-202-scripts.js

    });

+    this.tapBPM = function (channel, control, value, status, group) {
+        if (value == 127) {
+            bpm.tapButton(script.deckFromGroup(this.currentDeck));


You're right. I got some unexpected results, too. Let's improve this later on.

Lykos153 · 2018-04-12T00:55:02Z

Sorry for getting back to you so late. Was on the road, to I didn't have the controller to check it out. Good work! Just added some comments where I think we could still improve.

Thinking of your initial question, I guess it's time to map the right side as well. Now that it starts to be actually usable, it's very unsatisfying to only have the left half of it ;) . Did you already map it in your local xml? If not, I'm gonna do this tomorrow.

I don’t usually do any JS, so any nits welcome.

Neither do I, so same goes for you ;)

eigengrau · 2018-04-12T14:28:42Z

Sorry for getting back to you so late. Was on the road, to I didn't have the controller to check it out.

No worries, there’s no rush.

Did you already map it in your local xml? If not, I'm gonna do this tomorrow.

Most of them, except for the pads, iirc. I noticed I messed up the indentation though, because I had Emacs’ nXML-mode set to the default of two spaces, not four.

eigengrau added 3 commits April 9, 2018 18:33

Roland DJ-202: Map slip button

7f43a2a

Roland DJ-202: Map tap tempo button

62044ae

Roland DJ-202: Support strip search

6d07b1e

Lykos153 self-requested a review April 9, 2018 21:19

eigengrau added 2 commits April 10, 2018 18:32

Roland DJ-202: Map shifted FX inputs

aae792e

Since the shift button applies both to the FX racks as well as the decks, the button is now a property of the controller instance. - Shift+FX₁{1…4} ⇒ Cycle selected effect - Shift+Level-knob ⇒ Control FX rack super knob

Roland DJ-202: Map FX-rack headphones cue

9b14c84

eigengrau force-pushed the Mapping-DJ-202 branch from a17ed0d to 9b14c84 Compare April 10, 2018 16:32

eigengrau changed the title ~~Slip button, tap tempo, strip search~~ Slip button, tap tempo, strip search, FX button extras Apr 10, 2018

Roland DJ-202: Map beat grid functions

0bd482c

- Shift+Cue (“tap tempo”), short ⇒ tap tempo, align beat grid to play-back position - Shift+Cue (“tap tempo”), long ⇒ align beat grid to other deck

eigengrau force-pushed the Mapping-DJ-202 branch 2 times, most recently from 7c694b3 to 037cd2b Compare April 11, 2018 15:26

eigengrau commented Apr 11, 2018

View reviewed changes

Roland DJ-202: Map key shift functions

067e97f

- Key-Lock (long) + Param{Up,Down} ⇒ Shift musical key - Key-Lock (long) + ParamUp + ParamDown ⇒ Reset musical key

eigengrau force-pushed the Mapping-DJ-202 branch from 037cd2b to 067e97f Compare April 11, 2018 18:25

eigengrau added 3 commits April 11, 2018 21:05

Roland DJ-202: Replace deprecated control

1f111be

As per the wiki, ‘SelectTrackKnob’ is deprecated.

Roland DJ-202: Map shifted rotary encoder

8ce5fd1

Roland DJ-202: Map rotary encoder button push

69ea8d8

• Push ⇒ Move focus forward • Shift+Push ⇒ Move focus backward

eigengrau force-pushed the Mapping-DJ-202 branch 2 times, most recently from dddd386 to ebf6278 Compare April 11, 2018 20:12

Roland DJ-202: Map BPM reset

3b2e934

• Sync-Button (double-tap) ⇒ Reset deck BPM to file BPM

eigengrau force-pushed the Mapping-DJ-202 branch from ebf6278 to 3b2e934 Compare April 11, 2018 20:30

Lykos153 reviewed Apr 12, 2018

View reviewed changes

Lykos153 merged commit 2c866cd into Lykos153:Mapping-DJ-202 Apr 12, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Slip button, tap tempo, strip search, FX button extras #1

Slip button, tap tempo, strip search, FX button extras #1

eigengrau commented Apr 9, 2018

eigengrau commented Apr 9, 2018

eigengrau commented Apr 9, 2018

Lykos153 commented Apr 9, 2018 •

edited

Loading

Be-ing commented Apr 9, 2018

Lykos153 commented Apr 9, 2018

eigengrau commented Apr 10, 2018

eigengrau commented Apr 11, 2018 •

edited

Loading

eigengrau Apr 11, 2018

Lykos153 Apr 11, 2018

eigengrau commented Apr 11, 2018 •

edited

Loading

eigengrau commented Apr 11, 2018 •

edited

Loading

Lykos153 left a comment •

edited

Loading

Lykos153 left a comment •

edited

Loading

Lykos153 Apr 12, 2018

Lykos153 Apr 12, 2018

Lykos153 Apr 12, 2018

Lykos153 Apr 12, 2018

Lykos153 commented Apr 12, 2018 •

edited

Loading

eigengrau commented Apr 12, 2018

Slip button, tap tempo, strip search, FX button extras #1

Slip button, tap tempo, strip search, FX button extras #1

Conversation

eigengrau commented Apr 9, 2018

eigengrau commented Apr 9, 2018

eigengrau commented Apr 9, 2018

Lykos153 commented Apr 9, 2018 • edited Loading

Be-ing commented Apr 9, 2018

Lykos153 commented Apr 9, 2018

eigengrau commented Apr 10, 2018

eigengrau commented Apr 11, 2018 • edited Loading

eigengrau Apr 11, 2018

Choose a reason for hiding this comment

Lykos153 Apr 11, 2018

Choose a reason for hiding this comment

eigengrau commented Apr 11, 2018 • edited Loading

eigengrau commented Apr 11, 2018 • edited Loading

Lykos153 left a comment • edited Loading

Choose a reason for hiding this comment

Lykos153 left a comment • edited Loading

Choose a reason for hiding this comment

Lykos153 Apr 12, 2018

Choose a reason for hiding this comment

Lykos153 Apr 12, 2018

Choose a reason for hiding this comment

Lykos153 Apr 12, 2018

Choose a reason for hiding this comment

Lykos153 Apr 12, 2018

Choose a reason for hiding this comment

Lykos153 commented Apr 12, 2018 • edited Loading

eigengrau commented Apr 12, 2018

Lykos153 commented Apr 9, 2018 •

edited

Loading

eigengrau commented Apr 11, 2018 •

edited

Loading

eigengrau commented Apr 11, 2018 •

edited

Loading

eigengrau commented Apr 11, 2018 •

edited

Loading

Lykos153 left a comment •

edited

Loading

Lykos153 left a comment •

edited

Loading

Lykos153 commented Apr 12, 2018 •

edited

Loading