Code

feat: add PositiveDefinite#89

Code

Open

nicholaskl97 wants to merge 26 commits intoLuxDL:mainLuxDL/Boltz.jl:mainfrom nicholaskl97:positive-definite-containernicholaskl97/Boltz.jl:positive-definite-containerCopy head branch name to clipboard

+207-1

Commits

Commits on Feb 6, 2025

• feat: add PositiveDefinite and corresponding tests

  

  nicholaskl97

  authored and

  avik-pal

  committed
  ae7abe3

  Copy full SHA for ae7abe3

• Added NNlib import to Positive Definite Container test

  

  nicholaskl97

  authored and

  avik-pal

  committed
  2045879

  Copy full SHA for 2045879

• Including and exporting PositiveDefinite

  

  nicholaskl97

  authored and

  avik-pal

  committed
  9b1dc0e

  Copy full SHA for 9b1dc0e

• Fixed PositiveDefinite inner constructors

  

  nicholaskl97

  authored and

  avik-pal

  committed
  81471f0

  Copy full SHA for 81471f0

• Fixed incorrect function call in PositiveDefinite test

  

  nicholaskl97

  authored and

  avik-pal

  committed
  6363cc3

  Copy full SHA for 6363cc3

• Updated PositiveDefinite to account for possibly changing state of underlying model

  

  nicholaskl97

  authored and

  avik-pal

  committed
  55eb914

  Copy full SHA for 55eb914

• Replaced call to mapslices in PositiveDefinite with mapreduce(...,hcat,eachcol(...)) for compatibility with GPUArrays

  

  nicholaskl97

  authored and

  avik-pal

  committed
  ab907c1

  Copy full SHA for ab907c1

• Fixed broken call to mapreduce in PositiveDefinite

  

  nicholaskl97

  authored and

  avik-pal

  committed
  7f6b397

  Copy full SHA for 7f6b397

• Fixed typo in PositiveDefinite test and removed == from test in favor of comparing absolute difference with a small threshold

  

  nicholaskl97

  authored and

  avik-pal

  committed
  6828917

  Copy full SHA for 6828917

• Removed unnecessary definition of norm2 from PositiveDefinite

  

  nicholaskl97

  authored and

  avik-pal

  committed
  2616135

  Copy full SHA for 2616135

• Added ShiftTo container

  

  nicholaskl97

  authored and

  avik-pal

  committed
  38e05be

  Copy full SHA for 38e05be

• Removed vector fields from PositiveDefinite and ShiftTo

  

  nicholaskl97

  authored and

  avik-pal

  committed
  53d8ba2

  Copy full SHA for 53d8ba2

• Added init to PositiveDefinite call to mapreduce

  

  nicholaskl97

  authored and

  avik-pal

  committed
  e0cbdbb

  Copy full SHA for e0cbdbb

• Fixed typo in ShiftTo test

  

  nicholaskl97

  authored and

  avik-pal

  committed
  cb83a38

  Copy full SHA for cb83a38

• Formatting changes

  

  nicholaskl97

  authored and

  avik-pal

  committed
  3355dd8

  Copy full SHA for 3355dd8

• Added @allowscalar to PeriodicEmbedding when determining which indices to leave alone.

  

  nicholaskl97

  authored and

  avik-pal

  committed
  d23b1b3

  Copy full SHA for d23b1b3

• Forgot to import @allowscalar

  

  nicholaskl97

  authored and

  avik-pal

  committed
  87f072b

  Copy full SHA for 87f072b

• Removed @allowscalar from PeriodicEmbedding

  

  nicholaskl97

  authored and

  avik-pal

  committed
  3bc013c

  Copy full SHA for 3bc013c

• Trying to match types better in PositiveDefinite mapreduce for the sake of AutoTracker

  

  nicholaskl97

  authored and

  avik-pal

  committed
  8ee9267

  Copy full SHA for 8ee9267

• Make PositiveDefinite match/utilize WeightInitializers

  

  nicholaskl97

  authored and

  avik-pal

  committed
  8b0d183

  Copy full SHA for 8b0d183

• Forgot to import WeightInitializers

  

  nicholaskl97

  authored and

  avik-pal

  committed
  a721523

  Copy full SHA for a721523

• Removed unnecessary WeightInitializers import

  

  nicholaskl97

  authored and

  avik-pal

  committed
  2ccaa7a

  Copy full SHA for 2ccaa7a

• ShiftTo and PositiveDefinite no longer ignore state from one of the two calls to the underlying model

  

  nicholaskl97

  authored and

  avik-pal

  committed
  b62f1be

  Copy full SHA for b62f1be

• Simplified PositiveDefinite mapreduce

  

  nicholaskl97

  authored and

  avik-pal

  committed
  2a0d379

  Copy full SHA for 2a0d379

• Fixed PositiveDefinite erroring on taking the gradient of permutedims on an empty array. Noted broken Tracker gradient test for PositiveDefinite

  

  nicholaskl97

  authored and

  avik-pal

  committed
  b2531ae

  Copy full SHA for b2531ae

• Improved PositiveDefinite test code coverage

  

  nicholaskl97

  authored and

  avik-pal

  committed
  a5207d2

  Copy full SHA for a5207d2