Correct error flag, fix warnings

LunarWatcher · Aug 22, 2024 · abfbac6 · abfbac6
1 parent 5c78179
commit abfbac6
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -47,5 +47,5 @@ jobs:
       - name: Run build
         run: |
           mkdir build && cd build
-          cmake .. -DCMAKE_BUILD_TYPE=Release -DLINT=ON -DLINT_WARNINGS_AS_ERRORS=ON
+          cmake .. -DCMAKE_BUILD_TYPE=Release -DLINT=ON -DLINT_WARNINGS_ARE_ERRORS=ON
           make -j $(nproc)
diff --git a/src/hazel/data/dashboard/DashboardUpdaters.cpp b/src/hazel/data/dashboard/DashboardUpdaters.cpp
@@ -16,6 +16,10 @@ bool Updaters::updateDashboardData(DashboardData &data, long long& waitSecs) {
 
 bool Updaters::updateLinks(DashboardData& data, long long& waitSecs) {
     bool dirty = false;
+    if (!data.links) {
+        spdlog::error("Failed to update; data.links is nullptr");
+        return false;
+    }
     auto& links = *data.links;
     for (auto& link : links) {
         if (link.appType != LinkDynamicApp::_None) {

diff --git a/src/hazel/json/JsonImpl.cpp b/src/hazel/json/JsonImpl.cpp
@@ -13,7 +13,7 @@ void hazel::from_json(const nlohmann::json& i, Config& o) {
 
     if (i.contains("adapters")) {
         for (const auto& [adapterId, conf] : i.at("adapters").items()) {
-            auto& type = conf.at("type");
+            const auto& type = conf.at("type");
             if (type == "discord") {
                 o.adapters.insert({
                     adapterId,