Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monthly heatmap improperly defaults to Active returns #6

Closed
kartiksubbarao opened this issue Feb 6, 2024 · 0 comments · Fixed by #7
Closed

Monthly heatmap improperly defaults to Active returns #6

kartiksubbarao opened this issue Feb 6, 2024 · 0 comments · Fixed by #7

Comments

@kartiksubbarao
Copy link
Contributor

[copied from https://github.com/ranaroussi/quantstats/issues/278]

Due to lines like this in reports.py:
active = kwargs.get("active_returns", "False")
The active variable is incorrectly set to "False" instead of False.

This produces the wrong logic with a line like this in wrappers.py:
if active and benchmark is not None:

The fix is to change these lines in reports.py to:
active = kwargs.get("active_returns", False)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant