Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression with active returns in reports.py #13

Closed
kartiksubbarao opened this issue Feb 24, 2024 · 0 comments · Fixed by #14
Closed

Regression with active returns in reports.py #13

kartiksubbarao opened this issue Feb 24, 2024 · 0 comments · Fixed by #14

Comments

@kartiksubbarao
Copy link
Contributor

The #7 pull request for #6 fixed an issue with active_returns. However, this change was inadvertently reverted in a subsequent commit 784452d

[That commit also reverted the #8 fix, which solves another mystery I had yesterday :-)]

I will submit another pull request to re-apply the fix.
kartiksubbarao added a commit to kartiksubbarao/quantstats_lumi that referenced this issue Feb 24, 2024
@kartiksubbarao
Update reports.py
54e60d6 
closes Lumiwealth#13
@kartiksubbarao kartiksubbarao mentioned this issue Feb 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update reports.py kartiksubbarao/quantstats_lumi
1 participant
@kartiksubbarao