update master #575
Merged
update master #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that filled_quantity is not anymore positive, so the code should be updated.
…re exception handling so long runs don't error out.
after_market_closes() was getting the wrong price data from get_last_…
Preliminary IB REST API Support
Fix error when filled_quantity is negative in broker.py
…_exception_handling Added a flag that turns off using quote data by default
…ent Orders where the parent does not affect position/portfolio values, but the attached child orders do. extended trading: Tradier and other brokers allow specific assets like SPY to trade for an extra 15min passed 4pm market close. Strategies can now set "extended_trading_minutes" in their Broker object to enable this feature.
Multileg backtest
Hopefully Last small IB Render Fixes
historical data fix
|
You've used up your 5 PR reviews for this month under the Korbit Starter Plan. You'll get 5 more reviews on October 20th, 2024 or you can upgrade to Pro for unlimited PR reviews and enhanced features in your Korbit Console. |
|
I’ve found 7 issues in this PR, but you have exceeded your plan limits. Upgrade to Korbit Pro and ask for another review with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description by Korbit AI
What change is being made?
Enhance the backtesting and broker functionalities by adding support for multi-leg orders, improving data handling, and integrating Interactive Brokers REST API.
Why are these changes being made?
These changes are made to support more complex trading strategies involving multi-leg orders, improve the accuracy and efficiency of data handling during backtesting, and expand broker integration options by adding support for Interactive Brokers REST API, which provides a more robust and flexible trading environment. Additionally, improvements in logging and error handling enhance the overall reliability and maintainability of the system.