after_market_closes() was getting the wrong price data from get_last_… #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You've used up your 5 PR reviews for this month under the Korbit Starter Plan. You'll get 5 more reviews on October 20th, 2024 or you can upgrade to Pro for unlimited PR reviews and enhanced features in your Korbit Console. |
|
I’ve found 1 issues in this PR, but you have exceeded your plan limits. Upgrade to Korbit Pro and ask for another review with |
grzesir
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…price()
Description by Korbit AI
What change is being made?
Correct the logic in
get_last_priceto use the closing price after market closes and add exception handling in the polling process to prevent thread termination.Why are these changes being made?
The
after_market_closes()function was incorrectly using the opening price instead of the closing price, which could lead to inaccurate data analysis. The added exception handling in the polling process ensures that the polling thread remains operational even if an error occurs, improving the robustness of the system.