Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #4 (enhancement) Print line as is instead of interpreting it as column #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LukasWillin
Copy link
Contributor

See discussion of Issue #4

FYI, this PR is not ready yet for merging and was only created for a first review of the changes:

  • This branch has not been tested yet and may not work
  • To-do: Create automated tests.sh

@LukasWillin
Copy link
Contributor Author

Hey Luke
Just a heads up and sry for the radio silence. Currently there is a lot of private stuff I have to get done before I can move on with projects. I'll come back to you once I got time

@LukasWillin
Copy link
Contributor Author

For some reason, I cannot get the column_ansi.sh script to be parsed properly when run through shellspec on my Ubuntu 20.04 Virtual Machine. Will have to check tomorrow and hopefully fix the issue.
image

Running tests/test_column_ansi.sh is fine however. Must be some environment issue.

@LukasWillin
Copy link
Contributor Author

Seems to be a POSIX compliance issue. POSIX does not know Arrays. And that's why it fails whenever an array is initialized or added to. Though it is odd that it isn't an issue during GitHubs CI

@LukasWillin
Copy link
Contributor Author

Finally had some more time to try to get the tests to work locally. And in hindsight it should have been clear to me 😅
bash shellspec --format d tests/**/*.sh

Anyway, I am on it again and will try to fix it.

@LukasWillin LukasWillin force-pushed the enhancement/4_option_print_line_as_is branch from 65660cc to fa61c16 Compare August 29, 2023 09:24
@LukasWillin
Copy link
Contributor Author

LukasWillin commented Aug 29, 2023

Done - Fixed the tests. PR is ready for review 🎉
@LukeSavefrogs

@LukasWillin LukasWillin marked this pull request as ready for review August 29, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant