-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ColorParser component #289
base: master
Are you sure you want to change the base?
Conversation
Relates to #103 I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really cool, just a few changes I think you should review.
Do you have a list of places where you'll use this? I can think of the group list (in sidebar) and the header for each group, maybe also in the permission node for prefixes/displaynames
Co-authored-by: Sam Goodger <[email protected]>
Co-authored-by: Sam Goodger <[email protected]>
Just some heads up: As I found out every sessionData contains a list of prefix nodes, these are only for the group/user tough, and so wouldn't resolve inheritance like they normally would. Built some methods to resolve inheritance. Was asking myself what I should display now, the inheritited prefix, the one of the group/user or maybe both? Also generally, there is the chance a user changed their meta-formatting section which would then also not display the prefix like it would be in-game, even tough that's what it should do. |
I plan to tackle a lot of this when I eventually get around to redoing the web editor. The main problem I foresee is the inheritance calculation... May need a bit of help from @lucko to get something similar to LP's permission calculation working for JavaScript if we want to properly show which prefix/suffix a user/group will inherit. |
Adds a component to parse strings with color codes, eg. prefixes.
Currently only on the Group creation modal. (Click the "+" right of "Groups" and type in a prefix)
Preview available at https://tobi406-luckpermsweb-dev.netlify.app/editor/demo
ToDo
Closes #103