-
-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
future: add meta 3rd: busted #1556
future: add meta 3rd: busted #1556
Conversation
This is one I actually use and have my own documentation for that I can add to this tomorrow - it is getting late 🙂 |
Thanks for opening the PR and getting the ball rolling on this 👍 |
The documentation provided by the author of busted is too simple and I cannot provide too much detail. If you have something better to add, that would be great! |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
21594fa
to
270f0ae
Compare
I am not able to use this |
I read the source code, he provides this api, but should not use this api, unless you are developing a test tool |
There is a LOT that is undocumented under busted and luassert. Trying my best to cover everything... |
- Also removed unnecessary unique type for stub instances
Still need to get to matchers, but I think I got almost everything. |
This comment was marked as resolved.
This comment was marked as resolved.
Oh man, this is a very challenging one to annotate given all of the metatable magic. Props to y'all for taking it on! |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
I did not realize that there is SO many aliases. These are all valid and perform the same assertion: assert.number
assert.Number
assert.is.Number
assert.is.number
assert.is_number
assert.is_Number |
Looks like something that could be generated in script. |
At the moment it is not possible to derive all api, so I made a trade-off and added only the most simple and intuitive api. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should not move the luassert file to the top-level directory, it will be invalid
My favourite is |
I think it is now ready to be merged, thanks @carsakiller |
EDIT: It seems that my CI fails to receive email notifications is broken. |
Nicely done resolving the nesting! 👍 |
Is there a release planned that includes this? Would love to start using it. |
It will be in the next release which will probably be out in the next couple days 🙂 |
Awesome :) |
No description provided.