Skip to content

Conversation

@abc1763613206
Copy link
Collaborator

@abc1763613206 abc1763613206 commented Sep 2, 2025

This might solve the issue of the GLIBC version being too high.

fixes #276


Test build: https://github.com/abc1763613206/rune/actions/runs/17393055021

This might solve the issue of the GLIBC version being too high.

Signed-off-by: abc1763613206 <[email protected]>
@sourcery-ai
Copy link

sourcery-ai bot commented Sep 2, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Downgrades the GitHub Actions build runner to Ubuntu 22.04 to resolve GLIBC version compatibility issues.

File-Level Changes

Change Details Files
Downgrade CI build runner OS version to Ubuntu 22.04
  • Replace runs-on label in build-linux job from ubuntu-latest to ubuntu-22.04
.github/workflows/build.yml

Assessment against linked issues

Issue Objective Addressed Explanation
#276 Ensure that the Linux build of the program is compatible with Debian Bookworm by using a GLIBC version no higher than 2.36.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@dosubot dosubot bot added the P - Linux Linux system related issue label Sep 2, 2025
@abc1763613206 abc1763613206 requested a review from Losses September 2, 2025 08:16
@abc1763613206
Copy link
Collaborator Author

@Losses You should consider pushing a minor update to the v1 branch as needed, theoretically only for the non-Steam version (since I assume Steam's container wouldn't be affected by this).

@Losses Losses merged commit fa9788e into Losses:master Sep 2, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P - Linux Linux system related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dependency issue on Debian

2 participants