Skip to content

Conversation

@laosb
Copy link
Contributor

@laosb laosb commented Aug 21, 2025

Summary by Sourcery

Pin macOS CI runners to macOS 15 and select Xcode 16.4 for macOS and iOS build pipelines

CI:

  • Change runs-on from macos-latest to macos-15 for macOS and iOS build-and-release jobs
  • Add xcode-select commands to use Xcode 16.4 in CI setup scripts

Chores:

  • Fix whitespace in cargo install rinf_cli command

@sourcery-ai
Copy link

sourcery-ai bot commented Aug 21, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR pins macOS GitHub runners to the macos-15 environment and explicitly selects Xcode 16.4 in CI setup scripts to ensure consistent build tooling for Mac and iOS workflows.

Flow diagram for CI setup with Xcode 16.4 selection

flowchart TD
    Start([Start CI Job]) --> SelectRunner["Use macos-15 runner"]
    SelectRunner --> XcodeSelect["sudo xcode-select -s /Applications/Xcode_16.4.app"]
    XcodeSelect --> InstallDeps["Install dependencies (CocoaPods, lmdb, create-dmg, rinf_cli)"]
    InstallDeps --> Build["Run build steps"]
    Build --> End([End CI Job])
Loading

File-Level Changes

Change Details Files
Pin macOS runners to macos-15 for build-and-release jobs
  • Changed runs-on from macos-latest to macos-15 for build-macos
  • Changed runs-on from macos-latest to macos-15 for build-and-release-mac-app-store
  • Changed runs-on from macos-latest to macos-15 for build-and-release-ios-app-store
.github/workflows/build.yml
Explicitly select Xcode 16.4 in CI scripts
  • Added sudo xcode-select -s /Applications/Xcode_16.4.app to macOS install script
  • Added sudo xcode-select -s /Applications/Xcode_16.4.app to iOS setup script
scripts/macos_1_ci_install.sh
scripts/apple/ios/1_ci_setup_deps.sh
Fix whitespace in Cargo install command
  • Removed extra leading space before cargo install invocation
.github/workflows/build.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@laosb
Copy link
Contributor Author

laosb commented Aug 21, 2025

Test run on my fork: https://github.com/laosb/rune/actions/runs/17114806988

@laosb laosb marked this pull request as ready for review August 21, 2025 03:17
@Losses Losses merged commit 204ad61 into Losses:master Aug 21, 2025
0 of 2 checks passed
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@dosubot dosubot bot added the P - macOS macOS system related issue label Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P - macOS macOS system related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants