-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add fog of war feature to map #1798
Conversation
b1aaad2
to
a2bf968
Compare
Finally I was able to pull your branch as it is. So many thx for your efforts so far! Here is a list of things that need to be done before I can merge this.
The biggest hurdle of this feature: Create different views for each player server-side Currently tracing the ws messages reveal the complete game state tree, including units in fogged regions. And even worse: You can use browsers dev tools to create a breakpoint in I hope I haven't demotivated you to continue on this. But you have picked a very tricky feature to implement... |
Few notes:
If you'd like to help me alter server-side code in a way that doesn't break the game, then we can fix these issues together. Otherwise, you're talking about situations where players will be man-in-the-middle hacking server side data themselves in order to acquire visibility. I think most players either don't know how to do this or don't have any desire to cheat if they do. For the rest of the hackers, just don't allow it for tournaments or public games until it's ready. I'd say mark this feature as a beta version and let it be usable in some limited state until more permanent fixes arrive. People should see how it affects strategy and offer suggestions for improvement. |
Closes #1237