-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🛠️ fix: fix telegram sender #416
Conversation
Add .nerve.toml file with default settings for English language and issue labeling and formatting options. Close the issue with a report.
Indentation issue was causing incorrect message transcriptions.
WalkthroughThe recent updates enhance the contributor management system by introducing a new configuration file, Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- .nerve.toml (1 hunks)
- app/sender/telegram/init.py (1 hunks)
- llmkira/openai/request.py (1 hunks)
Files skipped from review due to trivial changes (1)
- .nerve.toml
Additional comments not posted (2)
llmkira/openai/request.py (1)
232-236
: LGTM! But verify the method usage in the codebase.The code changes are approved.
However, ensure that all calls to the
extract
method are correctly handled with the new retry mechanism.Verification successful
Verified: The
extract
method is correctly handled across the codebase.The method
extract
is used in several files, and there are no issues with the new retry mechanism.
llmkira/openai/cell.py
llmkira/logic/__init__.py
llmkira/extra/voice/__init__.py
llmkira/openai/request.py
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all method calls to `extract` are correctly handled. # Test: Search for the method usage. Expect: Only occurances of the new method signature. rg --type python -A 5 $'extract'Length of output: 62
Script:
#!/bin/bash # Description: Verify all method calls to `extract` are correctly handled. # Test: Search for the method usage. Expect: Only occurrences of the new method signature. rg --type py -A 5 $'extract'Length of output: 3428
app/sender/telegram/__init__.py (1)
73-81
: LGTM!The updated logic for assigning the
message_text
variable enhances the robustness of the code by considering bothtext
andcaption
attributes.
Summary by CodeRabbit