Skip to content

Conversation

@rbqvq
Copy link
Contributor

@rbqvq rbqvq commented Feb 8, 2026

Description

Use actions/setup-node instead of MSYS2.

Revert commit fix(build): using @rollup/wasm-node partial changes in #3905

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

Copy link
Member

@ReenigneArcher ReenigneArcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fast resolution on this!

Use actions/setup-node instead of MSYS2.

Revert commit `fix(build): using @rollup/wasm-node` partial changes in #3905

Signed-off-by: Coia Prant <coiaprant@gmail.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 8, 2026

@rbqvq
Copy link
Contributor Author

rbqvq commented Feb 8, 2026

It looks like fine.

I've manually mounted the NodeJS PATH.

I think we don't need a PATH for npm prefix.


CI PASSED at https://github.com/rbqvq/Sunshine/actions/runs/21802858672/job/62901261780


I'm going to sleep now.
I think everything's fine.
Please feel free to make any further changes.

@rbqvq rbqvq requested a review from ReenigneArcher February 8, 2026 18:31
@codecov
Copy link

codecov bot commented Feb 8, 2026

Bundle Report

Bundle size has no change ✅

@ReenigneArcher ReenigneArcher changed the title fix(build): fix rollup failing build(web-ui): fix rollup failing Feb 8, 2026
@ReenigneArcher ReenigneArcher added this to the windows-arm milestone Feb 8, 2026
@codecov
Copy link

codecov bot commented Feb 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 15.17%. Comparing base (5bd3a2b) to head (4c638fe).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4687      +/-   ##
==========================================
+ Coverage   15.14%   15.17%   +0.03%     
==========================================
  Files          95       95              
  Lines       19883    19883              
  Branches     9196     9196              
==========================================
+ Hits         3011     3018       +7     
- Misses      15684    15727      +43     
+ Partials     1188     1138      -50     
Flag Coverage Δ
Archlinux 11.19% <ø> (ø)
FreeBSD-14.3-aarch64 ?
FreeBSD-14.3-amd64 13.23% <ø> (ø)
Homebrew-ubuntu-22.04 13.54% <ø> (+0.11%) ⬆️
Linux-AppImage 11.60% <ø> (ø)
Windows-AMD64 13.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 16 files with indirect coverage changes

@ReenigneArcher ReenigneArcher merged commit 8aed1a8 into LizardByte:master Feb 8, 2026
77 of 83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants