-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
build(web-ui): fix rollup failing #4687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ReenigneArcher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fast resolution on this!
c86699c to
a99ba31
Compare
Use actions/setup-node instead of MSYS2. Revert commit `fix(build): using @rollup/wasm-node` partial changes in #3905 Signed-off-by: Coia Prant <coiaprant@gmail.com>
|
|
It looks like fine. I've manually mounted the NodeJS PATH. I think we don't need a PATH for npm prefix. CI PASSED at https://github.com/rbqvq/Sunshine/actions/runs/21802858672/job/62901261780 I'm going to sleep now. |
Bundle ReportBundle size has no change ✅ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4687 +/- ##
==========================================
+ Coverage 15.14% 15.17% +0.03%
==========================================
Files 95 95
Lines 19883 19883
Branches 9196 9196
==========================================
+ Hits 3011 3018 +7
- Misses 15684 15727 +43
+ Partials 1188 1138 -50
Flags with carried forward coverage won't be shown. Click here to find out more. |



Description
Use actions/setup-node instead of MSYS2.
Revert commit
fix(build): using @rollup/wasm-nodepartial changes in #3905Type of Change
Checklist
AI Usage