Skip to content

fix: environment variable loss for running processes during refresh#4654

Draft
Yundi339 wants to merge 2 commits intoLizardByte:masterfrom
qiin2333:fix_env
Draft

fix: environment variable loss for running processes during refresh#4654
Yundi339 wants to merge 2 commits intoLizardByte:masterfrom
qiin2333:fix_env

Conversation

@Yundi339
Copy link

@Yundi339 Yundi339 commented Feb 3, 2026

Description

This PR addresses an issue where triggering a refresh() (when a user updates the app module) would overwrite the environment variables of a currently running process. Specifically, it prevents the loss of dynamic SUNSHINE_* prefix variables which are essential for the active streaming session.

Screenshot

None

Issues Fixed or Closed

None

Roadmap Issues

None

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2026

@codecov
Copy link

codecov bot commented Feb 3, 2026

Bundle Report

Bundle size has no change ✅

@Yundi339 Yundi339 marked this pull request as draft February 6, 2026 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant