Draft
Conversation
5ecfd6d to
e2dbaec
Compare
Bundle ReportBundle size has no change ✅ |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4221 +/- ##
==========================================
+ Coverage 11.34% 12.01% +0.66%
==========================================
Files 92 92
Lines 17623 17625 +2
Branches 8109 8109
==========================================
+ Hits 2000 2118 +118
+ Misses 14917 14611 -306
- Partials 706 896 +190
Flags with carried forward coverage won't be shown. Click here to find out more.
|
e2dbaec to
3121286
Compare
|
3121286 to
d053212
Compare
Member
|
It looks like this PR has been idle for 90 days. If it's still something you're working on or would like to pursue, please leave a comment or update your branch. Otherwise, we'll be closing this PR in 10 days to reduce our backlog. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This PR intends to add tests for the system tray, and depends on #3818
It was originally to be included with 3818, but there are issues with the tests that need to be resolved in the different build environments and it was growing out of hand.
At the time of opening the PR, the tests succeed on Windows, but fail on Linux. Unknown status on macOS due to homebrew builds failing right now.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage