Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accessibility issues of dropdown menu. #471

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

yinuoyang01
Copy link

fix accessibility issues of the two dropdown menus

fix accessibility issues of the two dropdown menus
@Livinglist Livinglist changed the title Update main_view.dart fix: accessibility issues of dropdown menu. Sep 5, 2024
Copy link
Contributor

@SputNikPlop SputNikPlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestions

lib/screens/item/widgets/main_view.dart Show resolved Hide resolved
Copy link
Contributor

@SputNikPlop SputNikPlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed these

lib/screens/item/widgets/main_view.dart Outdated Show resolved Hide resolved
lib/screens/item/widgets/main_view.dart Outdated Show resolved Hide resolved
label: 'Comments Order',
hint: 'Select order to sort comments',
child: GestureDetector(
onTap: () {},
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the usage of this GestureDetector with empty callback?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants