-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: accessibility issues of dropdown menu. #471
base: master
Are you sure you want to change the base?
Conversation
fix accessibility issues of the two dropdown menus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed these
Co-authored-by: SputNikPlop <[email protected]>
Co-authored-by: SputNikPlop <[email protected]>
label: 'Comments Order', | ||
hint: 'Select order to sort comments', | ||
child: GestureDetector( | ||
onTap: () {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the usage of this GestureDetector with empty callback?
fix accessibility issues of the two dropdown menus