Improve Quality Summary #99
Conversation
This PR attempts to resolve Lissy93#10; however, I only just started using Web-Check and this may not be the preferred approach. That said, I’m happy to incorporate any feedback to make this PR more useful. :) One unresolved issue is related to `api/threats.js` which appears to indicate that GOOGLE_CLOUD_API_KEY may be intended to work for both Page Speed Insights (Lighthouse) and Google Safe Browsing. Any clarification here would be greatly appreciated. The gist of this update is to rename the API key environment variable and to provide a more direct URL to assist users with adding support for the Quality Summary section of the report. Additionally, this may introduce a breaking change for current users as they would need to modify their environment variables. I’m not sure how to best handle this type of situation.
✅ Deploy Preview for web-check ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Is it necessary to change the env var name?
I'm just thinking... this is going to be a breaking change if we do, for everyone whose already running the :latest container. And like you mentioned, it's the same key used for other checks relying on services provided by Google Cloud services
|
Totally not necessary and I'd be happy to resubmit without making that change! I'm unable to tell if that key I generated at https://developers.google.com/speed/docs/insights/v5/get-started is able to be used by the Google Safe Browsing service though. |
It's the same key, but you need to enable the safe browsing API in the Google dev dashboard |
This PR attempts to resolve #10; however, I only just started using Web-Check and this may not be the preferred approach. That said, I’m happy to incorporate any feedback to make this PR more useful. :)
One unresolved issue is related to
api/threats.jswhich appears to indicate thatGOOGLE_CLOUD_API_KEYmay be intended to work for both Page Speed Insights (Lighthouse) and Google Safe Browsing. Any clarification here would be greatly appreciated.The gist of this update is to rename the API key environment variable and to provide a more direct URL to assist users with adding support for the Quality Summary section of the report.
Additionally, this may introduce a breaking change for current users as they would need to modify their environment variables. I’m not sure how to best handle this type of situation.